Feature ? NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
9 Nov 2023

Summary of Changes

Changing Modal_Contact field to use new modal dialog.
The same as #40462 but for Contact.

Testing Instructions

Run npm install.

Create a menu for Contact item,
Select/edit value in "Choose a Contact" field.

Edit an Article and use insert Contact button.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

avatar Fedik Fedik - open - 9 Nov 2023
avatar Fedik Fedik - change - 9 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2023
Category Administration com_contact Repository NPM Change JavaScript
avatar Fedik Fedik - change - 9 Nov 2023
The description was changed
avatar Fedik Fedik - edited - 9 Nov 2023
avatar Fedik Fedik - change - 9 Nov 2023
Labels Added: Feature NPM Resource Changed PR-5.1-dev
7b694c1 9 Nov 2023 avatar Fedik Typo
avatar Quy Quy - test_item - 11 Nov 2023 - Tested successfully
avatar Quy
Quy - comment - 11 Nov 2023

I have tested this item ✅ successfully on 7b694c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42326.

avatar viocassel viocassel - test_item - 11 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 11 Nov 2023

I have tested this item ✅ successfully on 7b694c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42326.

avatar Quy Quy - change - 11 Nov 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42326.

avatar LadySolveig LadySolveig - change - 14 Nov 2023
Labels Added: ?
avatar LadySolveig LadySolveig - change - 14 Nov 2023
Labels Added: ?
Removed: ?
avatar LadySolveig LadySolveig - change - 14 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-14 10:16:34
Closed_By LadySolveig
Labels Added: ?
Removed: ?
avatar LadySolveig LadySolveig - close - 14 Nov 2023
avatar LadySolveig LadySolveig - merge - 14 Nov 2023
avatar LadySolveig
LadySolveig - comment - 14 Nov 2023

Thank you @Fedik !
And thanks for testing @viocassel @Quy

Add a Comment

Login with GitHub to post a comment