[#41416] - [5.0] Fix the submenu modules
- Fixed in Code Base
- 22 Aug 2023
- Medium
- Build: 5.0-dev
- # 41416
- Diff
- Digital-Peak:system/dashboard
User tests: Successful: Unsuccessful:
Pull Request for Issue #41414.
Summary of Changes
Uses the identity from the app instead of from $this. Adds the respective system test as well.
Testing Instructions
Open /administrator/index.php?option=com_cpanel&view=cpanel&dashboard=system.
Actual result BEFORE applying this Pull Request
Error.
Expected result AFTER applying this Pull Request
No error.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Modules Administration JavaScript Unit Tests |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I do not agree with the fix in this PR
Brian, use $app in the module layout is okay, it is defined. Same as $params, $module and some other stuff.
It may sounds confusing but it works like that long time, probably since 1.7
still dont have to like it
| Labels |
Added:
?
PR-5.0-dev
|
||
Thanks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-22 06:07:32 |
| Closed_By | ⇒ | HLeithner |
I have tested this item ✅ successfully on db38470
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41416.