PR-5.0-dev ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
21 Aug 2023

Follow-up Pull Request (PR) for PR #41259 .

Summary of Changes

Add update SQL scripts for migrating the filter parameters of relevant core field plugins and the fieldparams of relevant custom fields on update.

Testing Instructions

Have a clean 5.0.0-alpha3 or previous 5.0.0 alpha version or a 4.4-alpha3.

Create a few custom fields of types "text", "textarea" or "editor" for articles, and for some of these fields use the "Text" filter, for some use the filter from the plugin and for others use some other filter.

Now update to a new package build on the 5.0-dev branch for the actual result, or update to the patched package or custom update URL created by Drone for this PR for the expected result.

Then check the filter parameter of the fields plugins in the #__extensions table.

Then check the filter parameter of the field's fieldparams plugins in the #__fields table.

Finally create an article using the custom fields created before the update and save that article.

Actual result BEFORE applying this Pull Request

After an update, the parameters and fieldparams have not been migrated.

Expected result AFTER applying this Pull Request

After an update, the parameters and fieldparams have been migrated.

Saving the article with the custom fields works.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2023
Category SQL Administration com_admin Postgresql Installation
avatar richard67 richard67 - open - 21 Aug 2023
avatar richard67 richard67 - change - 21 Aug 2023
Status New Pending
avatar richard67 richard67 - change - 21 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 21 Aug 2023
avatar richard67 richard67 - change - 21 Aug 2023
Labels Added: ?
avatar richard67 richard67 - change - 21 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 21 Aug 2023
avatar richard67 richard67 - change - 21 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 21 Aug 2023
avatar richard67 richard67 - change - 21 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 21 Aug 2023
avatar richard67 richard67 - change - 21 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 21 Aug 2023
avatar richard67 richard67 - change - 21 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 21 Aug 2023
avatar laoneo laoneo - change - 22 Aug 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-08-22 06:44:37
Closed_By laoneo
avatar laoneo laoneo - close - 22 Aug 2023
avatar richard67
richard67 - comment - 22 Aug 2023

@laoneo Why did you close this PR? The new update SQL scripts are missing in Harald's PR.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2023
Category SQL Administration com_admin Postgresql Installation SQL Administration com_admin Postgresql
avatar laoneo laoneo - change - 22 Aug 2023
Status Closed New
Closed_Date 2023-08-22 06:44:37
Closed_By laoneo
avatar laoneo laoneo - change - 22 Aug 2023
Status New Pending
avatar laoneo laoneo - change - 22 Aug 2023
Status Pending Closed
avatar laoneo laoneo - reopen - 22 Aug 2023
avatar richard67
richard67 - comment - 22 Aug 2023

Rebased to 5.0-dev after PR #41259 has been merged.

avatar richard67 richard67 - change - 22 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 22 Aug 2023
avatar richard67 richard67 - change - 22 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 22 Aug 2023
avatar richard67 richard67 - change - 22 Aug 2023
Labels Added: PR-5.0-dev
avatar laoneo laoneo - test_item - 22 Aug 2023 - Tested successfully
avatar laoneo
laoneo - comment - 22 Aug 2023

I have tested this item ✅ successfully on 64883f4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41417.

avatar richard67
richard67 - comment - 22 Aug 2023

@laoneo Have you tested with both MySQL and PostgreSQL? Or only MySQL?

avatar HLeithner HLeithner - close - 22 Aug 2023
avatar HLeithner HLeithner - merge - 22 Aug 2023
avatar HLeithner
HLeithner - comment - 22 Aug 2023

thanks richard and allon

avatar laoneo
laoneo - comment - 22 Aug 2023

Only mysql

Add a Comment

Login with GitHub to post a comment