[#41415] - [5.0] replace deprecated Factory::getLanguage() code
- Closed
- 12 Sep 2023
- Medium
- Build: 5.0-dev
- # 41415
- Diff
- brianteeman:deprecated_code1
User tests: Successful: Unsuccessful:
Summary of Changes
Following the dictat that core should not be using any deprecated code this pr replaces all remaining uses of Factory::getLanguage() with its replacement Factory::getApplication()->getLanguage()
Testing Instructions
- enable debug lang and navigate the site and check that the languages load and the debug plugin reports no errors
- change
<rtl>0</rtl>to<rtl>1<rtl>in langmetadata.xml and repeat
Actual result BEFORE applying this Pull Request
deprecated code is used
Expected result AFTER applying this Pull Request
no deprecated code and everything still works as expected
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
i assume no documentation is needed for this
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_associations com_categories com_config com_contact com_content com_contenthistory com_fields com_finder |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-22 09:49:04 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
PR-5.0-dev
|
||
can you reopen it please? I just want to do a code review and my add some lines as suggestion.
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-08-22 09:49:04 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Pending |
re-opened as requested
closing - conflicts
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-12 20:33:06 |
| Closed_By | ⇒ | brianteeman |
Hi Brian! Should this one reopen? There is still deprecated code, at least at one location that I spotted.
https://github.com/joomla/joomla-cms/blob/5.0-dev/libraries/src/Language/Text.php#L69C40-L69C40
Thanks, I'm not merging this for alpha 4 because there are some lines that should be improved for example if we already have $app or if you it's called twice within some lines of code