[#41069] - [5.0] Fixes the versioning of npm tools
- Closed
- 27 Jun 2023
- Medium
- Build: 5.0-dev
- # 41069
- Diff
- dgrammatiko:5.0-dev-ver
User tests: Successful: Unsuccessful:
Pull Request for Issue #41066 .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Broken
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Front End Templates (site) |
| Status | New | ⇒ | Pending |
Aha, I didn't see that npm ci produced these. If this PR is preferred over the removal of the asset entries I will
| Title |
|
||||||
When we had the same issue in past, you had suggested a similar solution here #39408 (comment) , and I had made a PR with that: #39413 .
But this had caused a discussion, so I had closed that PR and had added back the assets with #39431 .
So I guess the same discussion "Ignoring missing files in build script is just asking for trouble." would again start here.
I think it's on @HLeithner to decide what he prefers, or if necessary discuss it with other maintainers.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-27 15:19:25 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
PR-5.0-dev
|
||
I'll close this one as I don't want to have the same conversation again...
@dgrammatiko Shouldn't the unrelated changes in the html files be reverted?