NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
27 Jun 2023

Pull Request for Issue #41066 .

Summary of Changes

This pull request (PR) removes the obsolete assets com_users.admin-users-mail.es5 and com_users.admin-users-mail from file build/media_source/com_users/joomla.asset.json.

They should have been removed with #40302 , but that was overlooked since the original PR #39374 also had forgotten to remove them, so they were not added back later with PR #39431 and then were not marked as deprecated with PR #40385 .

Testing Instructions

On a clean, current 5.0-dev branch, run php ./build/build.php --remote=HEAD --exclude-gzip --exclude-bzip2 to get the actual result, and do the same on the branch of this PR to get the expected result.

Actual result BEFORE applying this Pull Request

> joomla@5.0.0 versioning
> node build/build.js --versioning

[Error: ENOENT: no such file or directory, lstat '/home/richard/lamp/public_html/joomla-cms-5.0-dev/build/tmp/1687872657/media/com_users/js/admin-users-mail.min.js'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'lstat',
  path: '/home/richard/lamp/public_html/joomla-cms-5.0-dev/build/tmp/1687872657/media/com_users/js/admin-users-mail.min.js'
}
`npm run versioning` did not complete as expected.

Expected result AFTER applying this Pull Request

Build suceeds.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#98

avatar joomla-cms-bot joomla-cms-bot - change - 27 Jun 2023
Category Repository NPM Change
avatar richard67 richard67 - open - 27 Jun 2023
avatar richard67 richard67 - change - 27 Jun 2023
Status New Pending
avatar dgrammatiko
dgrammatiko - comment - 27 Jun 2023

@richard67 alternative: #41069

avatar HLeithner HLeithner - close - 27 Jun 2023
avatar HLeithner HLeithner - merge - 27 Jun 2023
avatar HLeithner HLeithner - change - 27 Jun 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-27 15:07:38
Closed_By HLeithner
Labels Added: NPM Resource Changed PR-5.0-dev

Add a Comment

Login with GitHub to post a comment