? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar charvimehradu
charvimehradu
9 May 2023

Add a test for com_privacy to create a request to export the information.

avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2023
Category JavaScript Unit Tests
avatar charvimehradu charvimehradu - open - 9 May 2023
avatar charvimehradu charvimehradu - change - 9 May 2023
Status New Pending
avatar laoneo
laoneo - comment - 10 May 2023

There are some code style issues and the test is failing.

avatar charvimehradu charvimehradu - change - 10 May 2023
Labels Added: ? PR-4.4-dev
avatar laoneo
laoneo - comment - 11 May 2023

Tests are still failing, when you click on the Artefacts link, you can navigate to the screenshot:
image

avatar charvimehradu
charvimehradu - comment - 11 May 2023

yes I am working on it

avatar charvimehradu
charvimehradu - comment - 11 May 2023

@laoneo The tests are still failing but this time its a new error that I'm familiar with: "Could not instantiate mail function." I faced the same issue in my local environment and found that enabling the SMTP server on MAMP resolved the error. I haven't yet been able to figure out how to change the server configuration through Cypress or the codebase, but I will continue to look after some time to find a solution and update you. In the meantime, I'd appreciate any hints anyone has.

avatar laoneo
laoneo - comment - 13 May 2023

When #40583 gets merged, then should also this one working. You can then actually test the mails as well.

avatar charvimehradu charvimehradu - change - 14 May 2023
Labels Added: ?
avatar laoneo
laoneo - comment - 15 May 2023

Can you add some tests to check if a correct mail was sended as I did in #40583?

avatar laoneo
laoneo - comment - 15 May 2023

The code frim com_config can be removed. The mail settings are set during installation already.

avatar laoneo
laoneo - comment - 16 May 2023

When two mails are sent out, can you also test the second mail? And can you add a second test with a menu item?

avatar laoneo
laoneo - comment - 16 May 2023

And the filename should be upper case.

avatar laoneo
laoneo - comment - 16 May 2023

Test is still failing. To simplify the test, you don't have to test for the full content just part of it is enough, so you can test if the second mail contains the body "Someone has created a request to export all personal information". I guess it is hard to test the full body correctly.

988d984 16 May 2023 avatar charvimehradu js cs
avatar laoneo laoneo - change - 17 May 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-17 08:40:27
Closed_By laoneo
Labels Removed: ?
avatar laoneo laoneo - close - 17 May 2023
avatar laoneo laoneo - merge - 17 May 2023
avatar laoneo
laoneo - comment - 17 May 2023

Nice one, thanks!

avatar charvimehradu
charvimehradu - comment - 17 May 2023

finally thanks! :)

Add a Comment

Login with GitHub to post a comment