I messed up my local installation

@mfleeson: me ? quite often too ?

Build is failing due to a missing , in the base.sql file and when that's manually corrected the announcement is displayed and closes. But does not appear to call the ajax to write back to the database. Need to investigate further now I have a working 4.4 site.

Please do not catch all the exceptions better to propagate them to the client.

I've come to the code this morning knowng that a lot of the changes being requested have been made and git tells me my fork which is based 4.4 is behind. It offered sync the fork which i clicked and it synced it with 4.3! so now it's saying i'm 140 commits ahead of 4.3. I don't understand how even though I created the fork on 4.4 and it worked fine yesterday it's now all gone back to 4.3. And I'm not sure how to get my fork back to 4.4 so I can make these last few uploads. Hope someone can help.

Overnight this PR has aquired extra files which are not part of my commit. When I try and remove them from the PR I get Looks like something went wrong!

We track these errors automatically, but if the problem persists feel free to contact us. In the meantime, try refreshing.

It just gets better, I have the definitive code but it wont let me push it and gives the error "remote: fatal: bad tree object fa00be88a9b5283659b312b36877286b9c8f1f08 remote: aborting due to possible repository corruption on the remote side.
fatal: protocol error: bad pack header"

Here's the final code - https://drive.google.com/file/d/1pOdbTct0oFA82X0A2sIHTfgWIeRHTRaY/view?usp=share_link

I think it should be back to normal, merged 4.3 into 4.4 and updated this pr.

Once this has built a package, I will download and test it all again and then upload any final changes.

I have tested this item ✅ successfully on 5781472

@mfleeson check mfleeson#2

I have tested this item ✅ successfully on fe52b52

In the testing i had to discover the plugin first, enabled plugin
then did the test and it was a suc6

I tested this using the drone/package produced and a clean install. The plugin was enabled and displayed and functioned correctly.
I am not sure why drone is failing.
It says Disk full - please upload later (failing artifacts-system-tests and phpmin-system-mysql)

I have tested this item ✅ successfully on fe52b52

I will wait with setting RTC as the system tests are still failing at making a new installation, and I don't know yet if that is related to this PR or now. I will test later today making a new installation to see what goes wrong. The SQL looks ok to me now after the last changes, but maybe I'm blind or it's something else.

@mfleeson Due to the branch update you just have made, the test count in the issue tracker was invalidated. I just have restored the count so the previous human tests are counted.

Normally when you made a PR and it has 2 good human tests, you should avoid unnecessary branch updates in order to not invalidate the counter.

This time it was ok because I think you want to see if system tests are passing. If that will not be the case, you or someone else or me should make a new installation with the installation package created with the branch of that PR by drone.

By the way drone might have a problem now due to a full hard disk. People are already working on it.

Should the plugin added to coreExtensions in ExtensionHelper.php?

Should the plugin added to coreExtensions in ExtensionHelper.php?

Yes, and in the previous PR this was the case after my review: https://github.com/joomla/joomla-cms/pull/40556/files#diff-45688fa5398ae3d4bab3daa80bc4d2ea4785370233b82a7326f9676f965ec9eb

But in this PR here it's missing again.

@mfleeson Please add it to the ExtensionHelper.php.

Should the plugin added to coreExtensions in ExtensionHelper.php?

Yes, and in the previous PR this was the case after my review: https://github.com/joomla/joomla-cms/pull/40556/files#diff-45688fa5398ae3d4bab3daa80bc4d2ea4785370233b82a7326f9676f965ec9eb

But in this PR here it's missing again.

@mfleeson Please add it to the ExtensionHelper.php.

What is going on? In my code and what I uploaded I added this to ExtensionsHelper but now its not there?

@mfleeson There are still some unresolved review comments by @heelc29 . Unfortunately they are hidden by default when you check the conversation comments here, and you have to use a "load more ..." button which is not easy to find. But you can see them when you go to the changed file here on GitHub: https://github.com/joomla/joomla-cms/pull/40565/files#diff-43fd4a40d7409ad1e608154c3e900ae13a92340cf68d97225fccdcc9e300c008 . Could you check them? Thanks in advance.

@richard67 I left those changes and tagged you for your input/review. He is suggesting changing the code so that language definitions load if the plugin actually needs to display. As I was told to keep this code as close to the core examples it currently autoloads the definitions so I wanted a 'senior' opinion on whether to implement his changes or not.

@mfleeson I think I know why the system tests are failing.

The good news: The installation test does not fail due to an SQL error. The installation succeeds when making a new installation with this branch.

But as described in the description of this PR, the EOS date has not been changed so it is still "2023-10-25", and so the message is shown:

This causes the system test to fail because it does not find the button in the statistics message.

@laoneo Could you advise regarding the system tests? Should they be adjusted for the case that the message is shown, otherwise they will stop to work when 4.4 will have reached the time when the message is shown? If so, then @mfleeson should maybe wait with adjusting the EOS date in this PR to the right one so we could first see if the modification of the tests works for that case. And could you advise regarding the necessary change of the system tests?

@mfleeson When the previous question regarding the system tests is clarified and the tests have been adjusted, if necessary, then you should set the EOS date in this PR to the right one and add something to the testing instructions how testers can modify the file to get it shown again, so that we have system tests passing again before people test.

@richard67 I left those changes and tagged you for your input/review. He is suggesting changing the code so that language definitions load if the plugin actually needs to display. As I was told to keep this code as close to the core examples it currently autoloads the definitions so I wanted a 'senior' opinion on whether to implement his changes or not.

@mfleeson There were also other review comments, not only those about the language loading, and for the language loading I am not really the right guy to decide how it should be done.

@mfleeson to fix the failing tests change this line

to

messageContainer.insertAdjacentHTML('afterbegin', Joomla.sanitizeHtml(json.html, allowed));

Thank you very much to all the testers and reviewers here, and especially @mfleeson for your great work. Just a short reminder. We will ship the first alpha on 30 May. So it would be cool to heave it ready in a proper state by the end of this week. Then we have enough time to iron out some bugs till the shipping date.

Thank you very much to all the testers and reviewers here, and especially @mfleeson for your great work. Just a short reminder. We will ship the first alpha on 30 May. So it would be cool to heave it ready in a proper state by the end of this week. Then we have enough time to iron out some bugs till the shipping date.

@laoneo @mfleeson It still needs to change the EOS date to the right value here: https://github.com/joomla/joomla-cms/pull/40565/files#diff-43fd4a40d7409ad1e608154c3e900ae13a92340cf68d97225fccdcc9e300c008R42 . We can't leave it like it is because the value '2023-10-25' was just for testing purpose.

On top of what @richard67 wrote above there's #40599 which fixes the tests (the last 2-3 commits). I guess @laoneo should decide if he wants the tests fixed with this PR or in another.

All I wanted to point out was that the failing tests should not hold back the progress of this pr. If they can get fixed it is even better.

When you click on the image with the text, a link will open in the same screen. It would be nicer to open the documentation in another screen (target="_blank"), like in the J3 plugin.
I don't see immediately a solution when I look at the code. Because J4 is something different.

An adjustment is not in a hurry at the moment. Can always do so later if we think this should be done.

@sandewt Yes, I've noticed that, too. It might be out of the scope of this PR here to fix that because it seems to be a general thing with the quickicons in J4.

FWIW #40602 should fix the failing tests so only the date should be changed here. @laoneo check the #40602

@mfleeson Thank you for your work - could you please change the date to correct value in 2025?

Update Eos.php - set hardcoded date to 2025-10-25

Something is wrong here, the date is not correct according to the roadmap.

The reason I hadn't set the final date was because it was being discussed at a recent meeting. Also the text definitions still need to be updated once finalised. Please reopen my branch. The current date from https://developer.joomla.org/roadmap.html is 17th October 2025 for end of support for J4.X

@MacJoom Could you please add the milestone for J4.4?