Feeling Lucky
PR-4.4-dev
[#40567] - [4.4] Deleted the unused `HelperFactory` use statement + minor changes custom module
- Fixed in Code Base
- 10 May 2023
- Medium
- Build: 4.4-dev
- # 40567
- Diff
- sandewt:patch-5
User tests: Successful: Unsuccessful:
Delete HelperFactory use statement+ minor changes to make code consistent with other modules
Pull Request for Issue # .
Summary of Changes
- Deleted the unused
HelperFactoryuse statement - Moved to above
defined('_JEXEC') or die; - Added a
voidreturn statement
Testing Instructions
- Code review
- Works
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
sandewt
- comment
- 10 May 2023
Maybe you can adjust the description so it doesn't scare others.
Oops, I don't want to
Adjust the description.
Thanks.
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-10 18:53:56 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
PR-4.4-dev
|
||
laoneo
- comment
- 10 May 2023
Thanks!
sandewt
- comment
- 10 May 2023
Thanks too.
@sandewt I was scared when I did read the "Delete HelperFactory class" in your description, but after checking the code change I've realized that you don't really delete the class, you only delete the use statement for that class in the changed file. Maybe you can adjust the description so it doesn't scare others.