Language Change NPM Resource Changed PR-4.4-dev Success

User tests: Successful: Unsuccessful:

avatar Mohammadkhan18
Mohammadkhan18
31 Mar 2023

Pull Request for Issue #37926
Issue with navigation menu and breakpoints
Clean installation of joomla 4.1.4 without any changes.
I noticed that on screens with resolutions between 768px (medium) and 992px (large), the navigation menu does not collapse to hamburger menu.
so i have change the bootstrap class it will automatically turn into a hamburger menu at smaller screen
related to #37926
Summary of Changes
After changing the class now the nav is responsive

Actual result BEFORE applying this Pull Request

No hamburger menu is created

Expected result AFTER applying this Pull Request
Automatically hamburger menu will created when screen size is reduced

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Mohammadkhan18 Mohammadkhan18 - open - 31 Mar 2023
avatar laoneo
laoneo - comment - 31 Mar 2023

I think you forgot to commit your changes.

avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2023
Category JavaScript Repository NPM Change SQL Installation Postgresql Libraries
avatar obuisard obuisard - change - 31 Mar 2023
Labels Added: NPM Resource Changed PR-4.4-dev
avatar Mohammadkhan18
Mohammadkhan18 - comment - 31 Mar 2023

I think you forgot to commit your changes.

Actually I haven't done any changes, just change my branch from 4.3 to 4.4 because in previous PR I have the branch 4.3 while doing pull request

avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2023
Category JavaScript Repository NPM Change SQL Installation Postgresql Libraries Administration com_redirect JavaScript Repository NPM Change SQL Installation Postgresql Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2023
Category JavaScript Repository NPM Change SQL Installation Postgresql Libraries Administration com_redirect SQL Administration com_admin Postgresql com_redirect JavaScript Repository NPM Change Installation Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2023
Category JavaScript Repository NPM Change SQL Installation Postgresql Libraries Administration com_redirect com_admin SQL Administration com_admin Postgresql com_redirect Language & Strings JavaScript Repository NPM Change Installation Libraries
avatar obuisard obuisard - change - 2 Apr 2023
Labels Added: Language Change
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2023
Category JavaScript Repository NPM Change SQL Installation Postgresql Libraries Administration com_redirect com_admin Language & Strings SQL Administration com_admin Postgresql com_redirect Language & Strings JavaScript Repository NPM Change Installation
avatar laoneo laoneo - change - 3 Apr 2023
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-03 07:18:14
Closed_By laoneo
avatar laoneo laoneo - close - 3 Apr 2023
avatar laoneo laoneo - merge - 3 Apr 2023
avatar laoneo
laoneo - comment - 3 Apr 2023

This here is accidentally used as upmerge pr, but I did the upmerge from 4.3 manually. Just a fyi.

Add a Comment

Login with GitHub to post a comment