[#40260] - [4.3] [Guided tours] Titles and Help
- New
- Medium
- Build: 4.3.0-beta5-dev
- # 40260
Steps to reproduce the issue
Code inspection using browser tools (and a lot of experience of Help pages).
This may seem like nit-picking but the issue gets propagated through translation. For the 4.x series we tried to make the Help page file names consistent with the page heading in which they occur. That involved renaming 250+ Help files in MediaWiki. So I noticed the following items need attention:
Page Titles:
Guided Tours - New Tour should be Guided Tours: New Tour
Guided Tours - Edit Tour should be Guided Tours: Edit Tour
Guided Tours - New Step should be Guided Tours: New Step (there is no Help button)
Guided Tours - Edit Step should be Guided Tours: Edit Step
Guided Tour: <Title of Tour> should be Guided Tour: Steps (<Title of Tour>) But the title of the tour could be in the steps/default.php template.
MediaWiki Help file names
Guided_Tours_Tours should be Guided_Tours
Expected result
Actual result
System information (as much as possible)
Additional comments
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
Can you clarify what is still outstanding here please
administrator/modules/mod_guidedtours.xml line 22 needs key="Admin_Modules:_Guided_Tours"
I only just changed the wiki filename and left a redirect so Help does not break - but the code really needs to be consistent with the naming convention.
Wait - I need to check the other items.
administrator/components/com_guidedtours/src/View/Tours/HtmlView.php line 173 needs to be help('Guided_Tours')
.../tmpl/emptystate.php line 19 needs Guided_Tours
administrator/language/en-GB/com_admin.ini needs Guided_Tours
The Guided Tour: Steps page is still missing ': Steps' and it is not normal to include the item title in the page title bar. If it is needed it could be moved to the default.php template.
I think that is it.
it is not normal to include the item title in the page title bar. If it is needed it could be moved to the default.php template.
this page is working the same as workflows/stages
The Workflows Stages pages do have appropriate titles but it is the same Help screen - Stages List: Basic Workflow. So should the Blog Workflow have its own screen? I am inclined to suggest not and the title should be Workflow: Stages.
The Guided Tours is the same but the Help screen is also the same for all tour steps - Guided Tours: Steps
Having the tour name in the title is a tad ugly because the Tour titles are rather long and half covered on my screen by the top bar module items.
Head back in sand?
Hackwar
- | Labels |
Added:
bug
|
||
| Labels |
Added:
PBF
|
||
| Labels |
Removed:
PBF
|
||
obuisard
- | Title |
|
||||||
| Labels |
Added:
Guided Tours
|
||
And I should have included a MediaWiki help file to rename:
Admin_Modules:_Tours_Menu should be Admin_Modules:_Guided_Tours
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40260.