? Language Change bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar khu5h1
khu5h1
30 Mar 2023

Pull Request for Issue #40210 .

Summary of Changes

Fixed missing field in Banners Tour.

Actual result BEFORE applying this Pull Request

When we go through the tutorial on how to create a banner, there are skipping fields, some of which are required.

Expected result AFTER applying this Pull Request

Now, it does not skip the fields and targets the entire details.

image

avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2023
Category SQL Administration com_admin Postgresql Language & Strings Installation
avatar khu5h1 khu5h1 - open - 30 Mar 2023
avatar khu5h1 khu5h1 - change - 30 Mar 2023
Status New Pending
avatar khu5h1 khu5h1 - change - 1 Apr 2023
Labels Added: Language Change ? PR-4.3-dev
avatar richard67
richard67 - comment - 1 Apr 2023

@khu5h1 Please do it like I suggest, update the values with one common update statement and use only the ID in the WHERE clause:

UPDATE `#__guidedtour_steps`
SET `title` = 'COM_GUIDEDTOURS_TOUR_BANNERS_STEP_DETAILS_TITLE', `description` = 'COM_GUIDEDTOURS_TOUR_BANNERS_STEP_DETAILS_DESCRIPTION', `target` = '.col-lg-9'
WHERE `id` = 63;

avatar khu5h1
khu5h1 - comment - 1 Apr 2023

@richard67 sure, updating the changes.

avatar Kostelano Kostelano - test_item - 1 Apr 2023 - Tested successfully
avatar Kostelano
Kostelano - comment - 1 Apr 2023

I have tested this item successfully on 1e366a7

It's all right now, thanks. A little generalized (large) field with details, but it's better than it was ;).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40258.

avatar Quy Quy - test_item - 1 Apr 2023 - Tested successfully
avatar Quy
Quy - comment - 1 Apr 2023

I have tested this item successfully on 1e366a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40258.

avatar Quy Quy - change - 1 Apr 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 Apr 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40258.

avatar Quy Quy - change - 1 Apr 2023
Labels Added: ?
avatar khu5h1 khu5h1 - change - 1 Apr 2023
Labels Removed: ?
avatar sdwjoomla sdwjoomla - change - 5 May 2023
Labels Added: bug
avatar sdwjoomla sdwjoomla - change - 5 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-05 03:17:39
Closed_By sdwjoomla
avatar sdwjoomla sdwjoomla - close - 5 May 2023
avatar sdwjoomla sdwjoomla - merge - 5 May 2023
avatar sdwjoomla
sdwjoomla - comment - 5 May 2023

Thanks khu5h1

Add a Comment

Login with GitHub to post a comment