[#40257] - [4.4] Converting File class from CMS to framework package
- Fixed in Code Base
- 3 Apr 2023
- Medium
- Build: 4.4-dev
- # 40257
- Diff
- Hackwar:4.4-filesystem-file-delete
User tests: Successful: Unsuccessful:
Summary of Changes
This PR changes the Joomla\CMS\Filesystem\File class over to Joomla\Filesystem\File where possible without any further changes. The remaining 12 files using the CMS class are using methods which aren't in the framework class or are in there differently.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners com_config com_finder com_joomlaupdate com_languages com_menus Installation Libraries Front End Plugins |
| Status | New | ⇒ | Pending |
The used code in the File classes are identical.
Why are then the system tests failing on various places?
Cypress, local test: test was NOT scuccessful
Before patch:
After patch: and so forth
Some additional information:
| Labels |
Added:
PR-4.4-dev
|
||
I reverted one file which had also calls to File::getExt(). That makes this all pass again.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-03 12:58:35 |
| Closed_By | ⇒ | laoneo |
Thanks!
This needs some proper testing as the system tests are crashing on various places. Really I would split this pr file by file and add proper testing instructions, just to be sure we do not break something.