? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
10 Mar 2023

Pull Request for Issue #40008.

Summary of Changes

The 'Next' button in a step can never be disabled if the target input field has a value.
Little code refactoring as well.

Testing Instructions

Run a tour, for instance 'Create a category'.
Once in the title field, the 'Next' button is disabled because the field is required.
Enter a value in the input field.
The 'Next' button is not enabled.
Go to the next step and go back to the previous step.
The 'Next' button should still be enabled.
Remove the value in the input field.
The 'Next' button should be disabled.

Actual result BEFORE applying this Pull Request

When returning to the step, the 'Next' button is disabled.
You need to give focus to the input field AND type something for the 'Next' button to be enabled.

Expected result AFTER applying this Pull Request

When returning to the step, the 'Next' button is enabled because there is a value for the required input field.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2023
Category JavaScript Repository NPM Change
avatar obuisard obuisard - open - 10 Mar 2023
avatar obuisard obuisard - change - 10 Mar 2023
Status New Pending
avatar obuisard obuisard - change - 10 Mar 2023
Title
When the input field has a value, the 'next' button should never be disabled
[4.3][Guided Tours] When the input field has a value, enable the 'next' button
avatar obuisard obuisard - edited - 10 Mar 2023
avatar obuisard obuisard - change - 10 Mar 2023
Title
[4.3][Guided Tours] When the input field has a value, enable the 'next' button
[4.3][Guided Tours] When the input field has a value, enable the 'Next' button
avatar obuisard obuisard - edited - 10 Mar 2023
avatar khu5h1 khu5h1 - test_item - 10 Mar 2023 - Tested successfully
avatar khu5h1
khu5h1 - comment - 10 Mar 2023

I have tested this item successfully on f36a7ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40062.

avatar obuisard obuisard - change - 10 Mar 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar brianteeman brianteeman - test_item - 11 Mar 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 Mar 2023

I have tested this item successfully on 73ccccf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40062.

avatar sdwjoomla sdwjoomla - test_item - 11 Mar 2023 - Tested successfully
avatar sdwjoomla
sdwjoomla - comment - 11 Mar 2023

I have tested this item successfully on 73ccccf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40062.

avatar Quy Quy - change - 11 Mar 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40062.

avatar obuisard obuisard - change - 11 Mar 2023
Labels Added: ?
avatar obuisard obuisard - change - 11 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-11 23:41:05
Closed_By obuisard
avatar obuisard obuisard - close - 11 Mar 2023
avatar obuisard obuisard - merge - 11 Mar 2023

Add a Comment

Login with GitHub to post a comment