? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
10 Mar 2023

Pull Request for Issue #40024.

Summary of Changes

The tour and step titles get a number when duplicated.
However, this is unnecessary, especially that it breaks translations if the title is a language key.

Testing Instructions

Go to the tours list view.
Edit a tour.
Save as Copy.
You should end up with a disabled tour but matching the one it was copied from.

Select one or several tours.
Go to 'Actions' and select 'Duplicate'.
You should end up with disabled tour(s) but matching the one(s) it(they) was(were) copied from.

Go to the step view of a tour (to access the step view, click on the number next to the tour in tours list view).
Edit a step.
Save as Copy.
You should end up with a disabled step but matching the one it was copied from.

Actual result BEFORE applying this Pull Request

A tour title could end up looking like:
COM_GUIDEDTOURS_TOUR_USERS_TITLE (2)
in tours list view because it can no longer be translated (if the original title is a language key).

Expected result AFTER applying this Pull Request

You get the proper translation for the tour if the title is a language key.
Titles no longer get an additional differentiable number.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2023
Category Administration
avatar obuisard obuisard - open - 10 Mar 2023
avatar obuisard obuisard - change - 10 Mar 2023
Status New Pending
avatar obuisard obuisard - change - 10 Mar 2023
Title
[4.3][Guided Tours] Removed unnecessary title generation on copy or duplicate
[4.3][Guided Tours] Remove unnecessary title generation on copy or duplicate
avatar obuisard obuisard - edited - 10 Mar 2023
avatar obuisard obuisard - change - 11 Mar 2023
Labels Added: PR-4.3-dev
avatar brianteeman brianteeman - test_item - 11 Mar 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 Mar 2023

I have tested this item successfully on b6012a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40063.

avatar Quy Quy - test_item - 11 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 11 Mar 2023

I have tested this item successfully on b6012a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40063.

avatar Quy Quy - change - 11 Mar 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40063.

avatar obuisard obuisard - change - 11 Mar 2023
Labels Added: ?
avatar obuisard obuisard - change - 11 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-11 20:29:08
Closed_By obuisard
avatar obuisard obuisard - close - 11 Mar 2023
avatar obuisard obuisard - merge - 11 Mar 2023

Add a Comment

Login with GitHub to post a comment