? No Code Attached Yet
avatar coolcat-creations
coolcat-creations
9 Mar 2023

Steps to reproduce the issue

In Joomla 4 the Email Templates were introduced with some changes to the placeholders. Therefore, some overrides that previously used placeholders like %s are not working anymore.

There must be some information somewhere that the Overrides of the Mails need to be changed
such as COM_USERS_EMAIL_PASSWORD_RESET_BODY and so on

Expected result

Overrides should still work, if not an information must be in the after installation message or somewhere else?

Actual result

Mails are send with %s unchanged placeholders

System information (as much as possible)

Site which was upgraded from J3 to J4

avatar coolcat-creations coolcat-creations - open - 9 Mar 2023
avatar joomla-cms-bot joomla-cms-bot - change - 9 Mar 2023
Title
J4 <> J3 Overrides not working anymore
J4 J3 Overrides not working anymore
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Mar 2023
avatar coolcat-creations coolcat-creations - change - 9 Mar 2023
Title
J4 J3 Overrides not working anymore
J4 J3 Email Overrides not working anymore
avatar coolcat-creations coolcat-creations - edited - 9 Mar 2023
avatar richard67
richard67 - comment - 9 Mar 2023

I assume you mean language overrides for email sending? The „email overrides“ in t he title of the is PR is misleading.

Anyway I think this can happen with any kind of language overrides for language strings which contain placeholders for parameters when the number of parameters changes in that string between Joomla versions. We have semantic versioning and maybe a b/c promise for that situation. But between 2 major versions 3 and 4 I would not expect it to be b/c. Major version changes should allow such changes in language strings. I would never expect that with a major version update language strings remain the same, and so I would expect changes and would know that I have to check my language overrides. That’s so clear that it does not need a postinstall message, a d as said is is not limited to the mail functions.

For these reasons I think this issue should be closed as expected behavior.

avatar obuisard
obuisard - comment - 9 Mar 2023

Many of my clients have had issues with codeMirror strings accepting different amount of values and would crash their upgraded site. Usually a proper language file update fixes those issues but I understand the frustration if this happen on language overrides manually created or in this case in email that are sent out. Since the email system was completely overhauled, although unfortunate, I would expect this behavior. Some users may not be as aware of these potential issues, and it's probably more an issue with providing the proper information to those who update their sites to Joomla 4.

avatar coolcat-creations
coolcat-creations - comment - 9 Mar 2023

Maybe the override changes system should be available for language strings as well?

avatar Hackwar Hackwar - change - 10 Mar 2023
Labels Added: ?
avatar Hackwar Hackwar - labeled - 10 Mar 2023
avatar wojtekxtx
wojtekxtx - comment - 11 Mar 2023

@coolcat-creations Just plain NO. This would introduce (even bigger) mess in codebase.

avatar brianteeman
brianteeman - comment - 11 Mar 2023

@wojtekxtx please explain why. Its a good suggestion.

avatar wojtekxtx
wojtekxtx - comment - 11 Mar 2023

@brianteeman Because it will mean new (possibly untested = unsafe) code added, more maintanance burden, more (unexpected) things may/will happen. You never know.

Im minimalist; less code = better;

avatar brianteeman
brianteeman - comment - 11 Mar 2023

Thats just an excuse for never adding or changing anything. trolling again

avatar wojtekxtx
wojtekxtx - comment - 11 Mar 2023

@brianteeman no. Its sad reality. More code means more maintenance, more possible attack vectors, more ways ţo exploit code etc.

It's crazy that today world is as deceptive as it's but that's reality.

avatar coolcat-creations
coolcat-creations - comment - 11 Mar 2023

due to code changes the previously added overrides are either not in use or outdated. Changing the email text language string caused a not documented backwards break. It would be good to see if an override was changed or at least list somewhere such changes.

avatar wojtekxtx
wojtekxtx - comment - 11 Mar 2023

@coolcat-creations Im all for (auto)generating list of overrides (hence thumb up).
Im suprised that, in well-established project as Joomla, there is a room for thing like breaking backward compatibility and allowing newly added code to make other part(s) of code outdated. Or is it lack of maintainabiity?

avatar brianteeman
brianteeman - comment - 11 Mar 2023

do you even use joomla

avatar coolcat-creations
coolcat-creations - comment - 11 Mar 2023

@brianteeman his comment tells he don't

avatar brianteeman
brianteeman - comment - 11 Mar 2023
avatar coolcat-creations coolcat-creations - change - 11 Mar 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-03-11 13:24:43
Closed_By coolcat-creations
avatar coolcat-creations coolcat-creations - close - 11 Mar 2023
avatar coolcat-creations
coolcat-creations - comment - 11 Mar 2023

So my issue is in fact a duplicate, and I close this and add a comment there. Thank you @brianteeman

Add a Comment

Login with GitHub to post a comment