[#40060] - [4.3] Revert 38576
- Fixed in Code Base
- 11 Mar 2023
- Medium
- Build: 4.3-dev
- # 40060
- Diff
- joomdonation:revert_38576
- Pending continuous-integration/appveyor/pr Waiting for AppVeyor build to complete Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR reverts #38576 , solves the release blocker #40052. The original change to the file administrator/components/com_tags/src/Table/TagTable.php is valid, only change to the file libraries/src/Table/ContentType.php is wrong . However, due to the limitation of the current tag routing, we require each tag to have unique alias, so I revert the the whole PR.
Testing Instructions
- Use Joomla 4.3-dev
- Try to install Hikashop extension which can be downloaded below
com_hikashop_starter_v4.7.1_2023-03-09_15-53-14.zip
Actual result BEFORE applying this Pull Request
You got error: Missing field in database: Joomla\CMS\Table\ContentType alias.
Expected result AFTER applying this Pull Request
No error, the extension was installed properly.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Administration Language & Strings Libraries |
| Labels |
Added:
Language Change
Release Blocker
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40060.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40060.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-11 22:59:08 |
| Closed_By | ⇒ | obuisard |
Thank you Tuan @joomdonation for the PR!
I have tested this item✅ successfully on 2ca9256
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40060.