Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39613] - Encode path parameters in MM API calls

? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
12 Jan 2023

Summary of Changes

The media manager crashes on several places when folders or files have special characters like "+" in their filename. This pr fixes this issue.

@dgrammatiko can you review this one?

Testing Instructions

  • Create by FTP or whatever you use images within folders with special characters like the "+"
  • Open the media manager
  • Rename such an image with a special character (don't worry, the character get removed, because of security in joomla, but this is ok)
  • Delete such an image
  • Select such an image in the article form for an article

Actual result BEFORE applying this Pull Request

Errors like file not found are thrown.

Expected result AFTER applying this Pull Request

All operations are working.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2023
Category ⇒ JavaScript Administration com_media NPM Change Repository
avatar laoneo laoneo - open - 12 Jan 2023
avatar laoneo laoneo - change - 12 Jan 2023
Status New ⇒ Pending
avatar laoneo laoneo - change - 12 Jan 2023
Labels Added: NPM Resource Changed ?
avatar dgrammatiko dgrammatiko - test_item - 12 Jan 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 12 Jan 2023

I have tested this item ✅ successfully on d1622c6

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39613.

avatar viocassel viocassel - test_item - 12 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 12 Jan 2023

I have tested this item ✅ successfully on 2d7fefd

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39613.

avatar Quy Quy - alter_testresult - 12 Jan 2023 - dgrammatiko: Tested successfully
avatar Quy Quy - change - 12 Jan 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 12 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39613.

avatar roland-d roland-d - close - 12 Jan 2023
avatar roland-d roland-d - merge - 12 Jan 2023
avatar roland-d roland-d - change - 12 Jan 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-01-12 15:13:54
Closed_By ⇒ roland-d
Labels Added: ?
avatar roland-d
roland-d - comment - 12 Jan 2023

Thank you.

Add a Comment

Login with GitHub to post a comment