Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39612] - [4.2] PHP8.2 Remove the not used method assignment in mm API

? PHP 8.x ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
12 Jan 2023

Summary of Changes

Removes the not used method variable in the media manager APIController.

Testing Instructions

Open the media manager on PHP 8.2

Actual result BEFORE applying this Pull Request

Media data is not loaded.

Expected result AFTER applying this Pull Request

Media data is loaded.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2023
Category ⇒ Administration com_media
avatar laoneo laoneo - open - 12 Jan 2023
avatar laoneo laoneo - change - 12 Jan 2023
Status New ⇒ Pending
avatar carlitorweb
carlitorweb - comment - 12 Jan 2023

@laoneo still the data not loading. But also is giving a js error

Uncaught SyntaxError: Unexpected token '<', "<br />
<b>"... is not valid JSON
    at JSON.parse (<anonymous>)
    at onSuccess (media-manager.js?c9d04fea6dae2c821fd73c99da6c9835:8113:45)
    at xhr.onreadystatechange (core.js?c9d04fea6dae2c821fd73c99da6c9835:669:23)

[with 8.2 only]

avatar laoneo laoneo - change - 13 Jan 2023
Labels Added: PHP 8.x ?
avatar laoneo
laoneo - comment - 13 Jan 2023

In the browser tools can you inspect the XHR request, what for a error message is displayed in the response?

avatar carlitorweb
carlitorweb - comment - 13 Jan 2023

Sorry, forgot that:

<b>Deprecated</b>: Using ${var} in strings is deprecated, use {$var} instead in <b>www\bugtesting\joomla-cms\libraries\vendor\voku\portable-utf8\src\voku\helper\UTF8.php</b> on line <b>13409</b>

avatar carlitorweb
carlitorweb - comment - 13 Jan 2023

But I confirm the error of the not used method variable and the patch fix it. The other error is not relate with this one

avatar carlitorweb carlitorweb - test_item - 13 Jan 2023 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 13 Jan 2023

I have tested this item ✅ successfully on d0c53b7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612.

avatar joomdonation joomdonation - test_item - 13 Jan 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 13 Jan 2023

I have tested this item ✅ successfully on d0c53b7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612.

avatar joomdonation joomdonation - change - 13 Jan 2023
Status Pending ⇒ Ready to Commit
avatar joomdonation
joomdonation - comment - 13 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612.

avatar roland-d roland-d - close - 14 Jan 2023
avatar roland-d roland-d - merge - 14 Jan 2023
avatar roland-d roland-d - change - 14 Jan 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-01-14 10:28:47
Closed_By ⇒ roland-d
Labels Added: ?
avatar roland-d
roland-d - comment - 14 Jan 2023

Thank you

Add a Comment

Login with GitHub to post a comment