? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Jan 2023

Converts from the ugly browser dependent alerts to use the joomla rendermessage

To test

run npm build:js or use a prebuilt package

Create and save an article and then edit it and save again Click on Versions
Click on all versions and then preview
Click on all versions and then restore
Click on one version and then compare

before - ugly alerts

image

after - joomla less ugly

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2023
Category JavaScript Repository NPM Change
avatar brianteeman brianteeman - open - 12 Jan 2023
avatar brianteeman brianteeman - change - 12 Jan 2023
Status New Pending
avatar brianteeman brianteeman - change - 12 Jan 2023
Labels Added: NPM Resource Changed ?
avatar viocassel viocassel - test_item - 12 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 12 Jan 2023

I have tested this item successfully on 124d167


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39611.

avatar dgrammatiko dgrammatiko - test_item - 12 Jan 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 12 Jan 2023

I have tested this item successfully on 124d167


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39611.

avatar Quy Quy - change - 12 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39611.

avatar roland-d roland-d - change - 12 Jan 2023
Labels Added: ?
avatar roland-d roland-d - change - 12 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-12 18:10:53
Closed_By roland-d
avatar roland-d roland-d - close - 12 Jan 2023
avatar roland-d roland-d - merge - 12 Jan 2023
avatar roland-d
roland-d - comment - 12 Jan 2023

Thank you

avatar brianteeman
brianteeman - comment - 12 Jan 2023

thanks for the quick tests and merge

Add a Comment

Login with GitHub to post a comment