? ? Pending

User tests: Successful: Unsuccessful:

avatar sandewt
sandewt
12 Jan 2023

Pull Request for Issue #38832 .

Summary of Changes

  • Choice of two icon images (Google Font)
  • Choice of a rectangular (default) or a circular shape image

Testing Instructions

  • Enable the 'System - Additional Accessibility Features' plugin
  • Select the "Use Google Material Font"
  • Test the different options, see the attached images
  • Code review

Actual result BEFORE applying this Pull Request

No option to choose an icon with a shape (Google Font)

Expected result AFTER applying this Pull Request

pr_accessibility-2

pr_accessibility-3
pr_accessibility-4png

Some notes

See links:

It has not researched of the "package": "accessibility", "version": "3.0.17" is still correct.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2023
Category Unit Tests Repository Administration com_admin SQL Postgresql com_associations com_banners
avatar sandewt sandewt - open - 12 Jan 2023
avatar sandewt sandewt - change - 12 Jan 2023
Status New Pending
avatar sandewt sandewt - change - 12 Jan 2023
Title
[4.3] [4.3] Accessibility Features Plugin: choice of two icon images (Google Font)
[4.3] Accessibility Features Plugin: choice of two icon images (Google Font)
avatar sandewt sandewt - edited - 12 Jan 2023
avatar sandewt sandewt - change - 12 Jan 2023
The description was changed
avatar sandewt sandewt - edited - 12 Jan 2023
avatar sandewt sandewt - edited - 12 Jan 2023
avatar sandewt sandewt - change - 12 Jan 2023
The description was changed
avatar sandewt
sandewt - comment - 12 Jan 2023

@richard67

Did I do something wrong when creating this PR ???
It concerns only size 3 files that I have modified for J4.3

avatar richard67
richard67 - comment - 12 Jan 2023

@sandewt It looks as if your branch for this PR is not based on the 4.2-dev branch for which the PR is made. Or did you want to make the PR for 4.3-dev? In this case you have made the PR for the wrong branch because it is made for the 4.2-dev branch.

avatar sandewt
sandewt - comment - 12 Jan 2023

@richard67

I think so too. I probably didn't create this PR for 4.3 properly, which was the intention.
What is Wisdom? Shall I close this PR?

avatar chmst
chmst - comment - 12 Jan 2023

@drmenzelit what is the state of the plugin? This PR seems to be in conflict with the current state

avatar sandewt
sandewt - comment - 12 Jan 2023

what is the state of the plugin? This PR seems to be in conflict with the current state

Something went wrong while creating this PR.

avatar sandewt
sandewt - comment - 12 Jan 2023

New pr #39615.

[EDIT]

avatar sandewt sandewt - close - 12 Jan 2023
avatar sandewt sandewt - change - 12 Jan 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-01-12 11:40:36
Closed_By sandewt
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment