User tests: Successful: Unsuccessful:
Pull Request for Issue #38832 .
(second attempt)
No option to choose from two different icons and a shape (Google Font)
See links:
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
- It is still Not possible to change the icon in the 'IconEmojis' mode
- It will require some documentation udates
[EDIT]
Category | ⇒ | Front End Plugins |
Status | New | ⇒ | Pending |
Labels |
Added:
PR-4.3-dev
|
Category | Front End Plugins | ⇒ | Administration Language & Strings Front End Plugins |
Title |
|
Title |
|
Labels |
Added:
Language Change
|
Good suggestion.
Good suggestion.
Done
Addition information: see the source code in browser (info for code review)
Use Emojis
"icon": {
"position": {
"left": {
"size": "0",
"units": "px"
}
},
"useEmojis": true,
"img": "",
"circular": ""
},
Use Google Material Font
"icon": {
"position": {
"left": {
"size": "0",
"units": "px"
}
},
"useEmojis": false,
"img": "accessible",
"circular": false
},
This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.
I have tested this item ✅ successfully on 3b1b154
I have tested this item ✅ successfully on 3b1b154
I have tested this item ? unsuccessfully on 3b1b154
Tested this at the PBF in Nijmegen in the online J5 server and got this error in Patch tester when applying the patch
YEs @brianteeman , I talked with @sandewt about this PR as he was also at the PBF. Just added my failed test for future reference
Is this problem going to be fixed:
The file marked for modification does not exist: plugins/system/accessibility/accessibility.php
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/39615">issues.joomla.org/tracker/joomla-cms/39615</a>.</sub>
Is this problem going to be fixed:
This PR is from last January, so it has been open for a while. If I have time, I will fix this code next week.
But there is still more work to be done, see PR #39161
Moreover, a newer version of the js is current. Maybe someone will want to fix that. My knowledge is insufficient to do that...
This pull request has been automatically rebased to 5.1-dev.
I have tested this item ? unsuccessfully on 3b1b154
The file marked for modification does not exist: plugins/system/accessibility/accessibility.php
I have tested this item ? unsuccessfully on 3b1b154
Button [Apply patch] results in error message
The file marked for modification does not exist: plugins/system/accessibility/accessibility.php
I have a question {perhaps a stupid one, I apologize if that's the case}, but while I love the idea of having choices for Google Fonts icons... the only way for using Google Fonts to be GDPR compliant is for that font to be locally hosted... and unless I missed something during my check of the Joomla 5 installation, there is no local such font file [.ttf or .woff2]. So, sure it is great to have a choice of icons but not if that means not being GPDR compliant.
So, if we are going to do this PR, can we update the PR to include a download/installation of the Google Fonts file and/or include that Google Fonts file as part of the Joomla installation?
ignoring the misconception about google fonts not being gdpr compliant this PR is now redundant and should be closed as larger updates to this plugin are in progress which will allow a local font/icon/svg.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-29 22:53:21 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
Feature
Conflicting Files
PR-5.0-dev
Removed: PR-4.3-dev |
Thanks all
Maybe it makes more sense to change the Radio form field type to a List form field type?
@bembelimen @laoneo What do you think of that?