Feature Language Change Conflicting Files PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar sandewt
sandewt
12 Jan 2023

Pull Request for Issue #38832 .
(second attempt)

Summary of Changes

  • Choice of two icon images (Google Font)
  • Choice of a rectangular (default) or a circular shape image

Testing Instructions

  • Enable the 'System - Additional Accessibility Features' plugin
  • Select the "Use Google Material Font"
  • Test the different options, see the attached images
  • Code review

Actual result BEFORE applying this Pull Request

No option to choose from two different icons and a shape (Google Font)

Expected result AFTER applying this Pull Request

pr_accessibility-2

pr_accessibility-3
pr_accessibility-4png

Some notes

  • It has not researched of the "package": "accessibility", "version": "3.0.17" is still correct.

See links:

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Open questions

- It is still Not possible to change the icon in the 'IconEmojis' mode
- It will require some documentation udates

[EDIT]

avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2023
Category Front End Plugins
avatar sandewt sandewt - open - 12 Jan 2023
avatar sandewt sandewt - change - 12 Jan 2023
Status New Pending
avatar sandewt sandewt - change - 12 Jan 2023
Labels Added: PR-4.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2023
Category Front End Plugins Administration Language & Strings Front End Plugins
avatar sandewt sandewt - change - 12 Jan 2023
Title
[4.3] Accessibility Features Plugin: choice of two icon images icon images
[4.3] Accessibility Features Plugin: choice of two icon images (Google Font)
avatar sandewt sandewt - edited - 12 Jan 2023
avatar sandewt sandewt - change - 12 Jan 2023
The description was changed
avatar sandewt sandewt - edited - 12 Jan 2023
avatar sandewt sandewt - change - 12 Jan 2023
Title
[4.3] Accessibility Features Plugin: choice of two icon images (Google Font)
[4.3] Accessibility Features Plugin: choice of two different icon images (Google Font)
avatar sandewt sandewt - edited - 12 Jan 2023
avatar laoneo laoneo - change - 12 Jan 2023
Labels Added: Language Change
avatar sandewt sandewt - change - 13 Jan 2023
The description was changed
avatar sandewt sandewt - edited - 13 Jan 2023
avatar sandewt sandewt - change - 13 Jan 2023
The description was changed
avatar sandewt sandewt - edited - 13 Jan 2023
avatar sandewt sandewt - edited - 13 Jan 2023
avatar sandewt sandewt - change - 13 Jan 2023
The description was changed
avatar sandewt
sandewt - comment - 28 Jan 2023

Maybe it makes more sense to change the Radio form field type to a List form field type?

@bembelimen @laoneo What do you think of that?

àccessibility_3

avatar laoneo
laoneo - comment - 28 Jan 2023

Good suggestion.

avatar sandewt
sandewt - comment - 30 Jan 2023

Good suggestion.

Done

avatar sandewt
sandewt - comment - 30 Jan 2023

Addition information: see the source code in browser (info for code review)

Use Emojis

"icon": {
            "position": {
                "left": {
                    "size": "0",
                    "units": "px"
                }
            },
            "useEmojis": true,
            "img": "",
            "circular": ""
        },

Use Google Material Font

"icon": {
            "position": {
                "left": {
                    "size": "0",
                    "units": "px"
                }
            },
            "useEmojis": false,
            "img": "accessible",
            "circular": false
        },
avatar sandewt
sandewt - comment - 2 Feb 2023

@drmenzelit

Related to "Update accessibility plugin to version 4.5.3 #39161

avatar HLeithner
HLeithner - comment - 8 May 2023

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

avatar rachelwalraven rachelwalraven - test_item - 26 Aug 2023 - Tested successfully
avatar rachelwalraven rachelwalraven - test_item - 26 Aug 2023 - Tested successfully
avatar rachelwalraven
rachelwalraven - comment - 26 Aug 2023

I have tested this item ✅ successfully on 3b1b154


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39615.

avatar rachelwalraven
rachelwalraven - comment - 26 Aug 2023

I have tested this item ✅ successfully on 3b1b154


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39615.

avatar hvdmeer hvdmeer - test_item - 26 Aug 2023 - Tested unsuccessfully
avatar hvdmeer
hvdmeer - comment - 26 Aug 2023

I have tested this item ? unsuccessfully on 3b1b154

Tested this at the PBF in Nijmegen in the online J5 server and got this error in Patch tester when applying the patch
afbeelding


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39615.
avatar brianteeman
brianteeman - comment - 26 Aug 2023

@hvdmeer that was because there are conflicting files as whon in your screenshot

avatar hvdmeer
hvdmeer - comment - 30 Aug 2023

YEs @brianteeman , I talked with @sandewt about this PR as he was also at the PBF. Just added my failed test for future reference

avatar ceford
ceford - comment - 15 Sep 2023

Is this problem going to be fixed:

The file marked for modification does not exist: plugins/system/accessibility/accessibility.php
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/39615">issues.joomla.org/tracker/joomla-cms/39615</a>.</sub>
avatar sandewt
sandewt - comment - 15 Sep 2023

Is this problem going to be fixed:

This PR is from last January, so it has been open for a while. If I have time, I will fix this code next week.

But there is still more work to be done, see PR #39161

Moreover, a newer version of the js is current. Maybe someone will want to fix that. My knowledge is insufficient to do that...

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar fgsw fgsw - test_item - 1 Dec 2023 - Tested unsuccessfully
avatar fgsw
fgsw - comment - 1 Dec 2023

I have tested this item ? unsuccessfully on 3b1b154

The file marked for modification does not exist: plugins/system/accessibility/accessibility.php
Untitled 2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39615.
avatar crimle crimle - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar crimle
crimle - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 3b1b154

Button [Apply patch] results in error message
The file marked for modification does not exist: plugins/system/accessibility/accessibility.php


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39615.

avatar exlemor
exlemor - comment - 29 Mar 2024

@sandewt

I have a question {perhaps a stupid one, I apologize if that's the case}, but while I love the idea of having choices for Google Fonts icons... the only way for using Google Fonts to be GDPR compliant is for that font to be locally hosted... and unless I missed something during my check of the Joomla 5 installation, there is no local such font file [.ttf or .woff2]. So, sure it is great to have a choice of icons but not if that means not being GPDR compliant.

So, if we are going to do this PR, can we update the PR to include a download/installation of the Google Fonts file and/or include that Google Fonts file as part of the Joomla installation?

avatar brianteeman
brianteeman - comment - 29 Mar 2024

ignoring the misconception about google fonts not being gdpr compliant this PR is now redundant and should be closed as larger updates to this plugin are in progress which will allow a local font/icon/svg.

avatar Quy
Quy - comment - 29 Mar 2024

Closing in favor of #43143. Thank you.

avatar Quy Quy - close - 29 Mar 2024
avatar Quy Quy - change - 29 Mar 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-03-29 22:53:21
Closed_By Quy
Labels Added: Feature Conflicting Files PR-5.0-dev
Removed: PR-4.3-dev
avatar sandewt
sandewt - comment - 30 Mar 2024

Thanks all

Add a Comment

Login with GitHub to post a comment