Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39393] - [5.0] Tinymce dark theme support

NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
11 Dec 2022

Pull Request for Issue # .

Summary of Changes

This is a draft just to showcase that there is no need for an extra PHP Event as the dark theme IS A CLIENT thing...

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Screen.Recording.2022-12-11.at.11.10.17.mov

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 11 Dec 2022
Category ⇒ JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - open - 11 Dec 2022
avatar dgrammatiko dgrammatiko - change - 11 Dec 2022
Status New ⇒ Pending
e853c0d 11 Dec 2022 avatar dgrammatiko cs
avatar dgrammatiko dgrammatiko - change - 11 Dec 2022
Labels Added: NPM Resource Changed PR-5.0-dev
avatar brianteeman
brianteeman - comment - 11 Dec 2022

This is targetted for tinymce 6.1+ ?

avatar dgrammatiko
dgrammatiko - comment - 11 Dec 2022

This is targetted for tinymce 6.1+ ?

There is nothing special for 6.1 so it can be back ported to 4.3. That said there are couple of things that need some consideration here namely:

  • Skins overrides My long stand is that the overrides should happen in the template #29259
  • editor.css This needs some further thinking but I honestly believe it's time to merge #35669 or something similar not only for the editor.css but also for making tinyMCE created content CSP valid!
avatar dgrammatiko dgrammatiko - change - 15 Dec 2022
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-12-15 08:31:56
Closed_By ⇒ dgrammatiko
avatar dgrammatiko
dgrammatiko - comment - 15 Dec 2022

Closing this one in favour of #39400 but probably that PR should also be broken to more meaningful parts once there's a consensus on the implementation, colours, etc

avatar dgrammatiko dgrammatiko - close - 15 Dec 2022

Add a Comment

Login with GitHub to post a comment