[#39395] - Invalid void return type
- Fixed in Code Base
- 28 Feb 2023
- Medium
- Build: 4.2-dev
- # 39395
- Diff
- SharkyKZ:j4/void
User tests: Successful: Unsuccessful:
Summary of Changes
void can only be used as standalone type.
Testing Instructions
Review.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
I noticed some inconsistencies:
In: diff --git a/libraries/src/Application/CMSApplication.php b/libraries/src/Application/CMSApplication.php
-
* @return mixed The previous state, if one existed. Null otherwise.
Should that be mixed|null
In: diff --git a/libraries/src/Application/CMSWebApplicationInterface.php b/libraries/src/Application/CMSWebApplicationInterface.php
-
* @return mixed The previous state, if one existed. Null otherwise.
Should that be mixed|null
And there is no actual code change in this one
Otherwise, I am probably not qualified to test this!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39395.
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-28 14:04:26 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
|
||
Thank you
I have tested this item✅ successfully on a2a5a60
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39395.