NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
30 Apr 2022

Pull Request for Issue #37640 .

Summary of Changes

  • Call the Custom Element function setValue instead of manually updating the value

Testing Instructions

  • Edit an article and go to the images tab
  • Open the inspector and inspect the intro image input (the one left to the select button bellow the image)
  • type in the browser's console $0.addEventListener('change', (e) => console.log(e))
  • Select an image, check that a change event was recorded in the console
  • Clear the field, check the recorded event
  • Select another image and check that the event was recorded again

Actual result BEFORE applying this Pull Request

No event on image selection

Expected result AFTER applying this Pull Request

Documentation Changes Required

No this is a bug

BTW this is already fixed in 4.2 with #37654 and merging this will not end up in conflicts when syncing the 2 repos.

avatar dgrammatiko dgrammatiko - open - 30 Apr 2022
avatar dgrammatiko dgrammatiko - change - 30 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2022
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 30 Apr 2022
Labels Added: NPM Resource Changed ?
avatar dgrammatiko dgrammatiko - change - 6 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-06 10:04:48
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 6 Jun 2022

Add a Comment

Login with GitHub to post a comment