? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
30 Apr 2022

Pull Request for Issue #37439 .

Summary of Changes

  • Invalid SVG files with broken structure
  • Allows comments in SVG files

Testing Instructions

Allow svg in the media manager options (mime: image/svg+xml, extension: svg).
Take the file package from @brianteeman #37439 (comment) and try uploading the files.

Actual result BEFORE applying this Pull Request

bad1.svg + bad3.svg is uploaded (both should be blocked), bad2.svg (false positive) + bad4.svg is rejected

Expected result AFTER applying this Pull Request

only "bad2.svg" is uploaded all other files are rejected

@woluweb could you test please?

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar bembelimen bembelimen - open - 30 Apr 2022
avatar bembelimen bembelimen - change - 30 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2022
Category Libraries
avatar brianteeman
brianteeman - comment - 1 May 2022

I have tested this item successfully on 7d05411


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37703.

avatar brianteeman brianteeman - test_item - 1 May 2022 - Tested successfully
avatar toivo
toivo - comment - 1 May 2022

I have tested this item successfully on 7d05411

Tested successfully in Joomla 4.1.3-dev of 30 April in Wampserver 3.2.8 using PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37703.

avatar toivo toivo - test_item - 1 May 2022 - Tested successfully
avatar chmst chmst - change - 1 May 2022
Status Pending Ready to Commit
avatar chmst
chmst - comment - 1 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37703.

avatar richard67 richard67 - change - 1 May 2022
Labels Added: ? ?
avatar akshitrattan
akshitrattan - comment - 1 May 2022

I have tested this item successfully on 0816b10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37703.

avatar akshitrattan akshitrattan - test_item - 1 May 2022 - Tested successfully
avatar richard67 richard67 - alter_testresult - 1 May 2022 - brianteeman: Tested successfully
avatar richard67 richard67 - alter_testresult - 1 May 2022 - toivo: Tested successfully
avatar bembelimen bembelimen - change - 1 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-01 11:31:09
Closed_By bembelimen
avatar bembelimen bembelimen - close - 1 May 2022
avatar bembelimen bembelimen - merge - 1 May 2022
avatar bembelimen
bembelimen - comment - 1 May 2022

Thx for testing

Add a Comment

Login with GitHub to post a comment