[#37701] - [4.2] Mail Templates htmlbody
- Fixed in Code Base
- 16 Jun 2022
- Medium
- Build: 4.1-dev
- # 37701
- Diff
- brianteeman:mail_templates_html
User tests: Successful: Unsuccessful:
Summary of Changes
html emails are much much bigger than plain text emails. Using some email templates from beefree.io was almost impossible as they were all too big to be saved. Checking the database the field type was TEXT and yet for the fulltext field in #__content MEDIUMTEXT was used. So it wasnt even possible to use an entire article in the mail template.
This PR changes the field to MEDIUMTEXT in mysql for updates and new installations. Note postgres doesnt need any change as it only has one datatype for text.
Testing Instructions
Upgrade with the prebuilt test packages and check the datatype of the htmlbody field in the #__mail_templates table
Clean install with he prebuilt test packages and check the datatype of the htmlbody field in the #__mail_templates table
check of the database checker in the system dashboard.
. In case of an update to the patched package for the PR, the checker should only show the usual error about not matching CMS version when using such packages, and in case of a new installation no errors should be shown.
Actual result BEFORE applying this Pull Request
TEXT
Expected result AFTER applying this Pull Request
MEDIUMTEXT
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Installation |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37701.
@brianteeman It needs to rename the update SQL script. Assuming that this PR remains on the 4.1-dev branch, it should be a name with version 4.1.5, and when 4.1.5 is released before this PR is merged, it needs a name with version 4.1.6. But I think the PR should be rebased to 4.2-dev. If this is the case, it needs a name with version 4.2.0 and a later date than 2022-05-15 (because "4.2.0-2022-05-15.sql" is the latest 4.2.0 update SQL script).
@roland-d Shall this PR be rebased to 4.2-dev?
I await your response before making any changes. To be clear this is NOT a new feature it is fixing a bug
I await your response before making any changes. To be clear this is NOT a new feature it is fixing a bug
@brianteeman I know. But 4.1.5 is already in RC phase, so @bembelimen will merge only extremely urgent bug fixes (or release blocker), and very likely will be the last 4.1.x release, as far as I know, so it will go in 4.2-dev anyway.
| Title |
|
||||||
| Labels |
Added:
?
Maintainers Checked
|
||
Rebased to 4.2 and changed the filename
I’ve restored the previous human test result in the issue tracker because the changes which invalidated the test count were just a clean rebase and the rename of the update SQL script (which I reviewed).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37701.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37701.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-16 06:54:11 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
Removed: ? |
||
Thanks everybody
@brianteeman To make it perfect you could add the check of the database checker in each case (update or new install) to the testing instructions. In case of an update to the patched package for the PR, the checker should only show the usual error about not matching CMS version when using such packages, and in case of a new installation no errors should be shown.