PR-4.0-dev NPM Resource Changed

Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
2 Oct 2021

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Apply the PR
Change the Session Lifetime (minutes) to 1 in Global Configuration -> System
Observe the Other in the network tab of your browser's console

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Screenshot 2021-10-02 at 13 11 26

Documentation Changes Required

None, We're switching from XHR to sendBeacon which is widely supported
https://caniuse.com/beacon
Screenshot 2021-10-02 at 13 25 43

avatar dgrammatiko dgrammatiko - open - 2 Oct 2021
avatar dgrammatiko dgrammatiko - change - 2 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2021
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 2 Oct 2021
Labels Added: PR-4.0-dev NPM Resource Changed
avatar dgrammatiko
dgrammatiko - comment - 2 Oct 2021

@Stuartemk yes all these are correct...

Edit: probably you're totally unaware how Joomla is dealing with the static assets, please read the readme.md: https://github.com/joomla/joomla-cms/tree/4.0-dev/build

avatar Stuartemk
Stuartemk - comment - 2 Oct 2021

@Stuartemk yes all these are correct...

Edit: probably you're totally unaware how Joomla is dealing with the static assets, please read the readme.md: https://github.com/joomla/joomla-cms/tree/4.0-dev/build

Ok
What I saw is the difference that one is es5 and another is es6

I do not understand why, I admit my lack of knowledge, but since I mentioned that and you confirm that it is well I trust.

avatar Fedik
Fedik - comment - 3 Oct 2021

Simplifying turns out not to simple 😄

avatar Fedik
Fedik - comment - 3 Oct 2021

I have tested this item successfully on 1652beb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35725.

avatar Fedik Fedik - test_item - 3 Oct 2021 - Tested successfully
avatar ditsuke
ditsuke - comment - 6 Oct 2021

I have tested this item successfully on 1652beb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35725.

avatar ditsuke ditsuke - test_item - 6 Oct 2021 - Tested successfully
avatar richard67 richard67 - change - 7 Oct 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 7 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35725.

avatar bembelimen bembelimen - close - 7 Oct 2021
avatar bembelimen bembelimen - merge - 7 Oct 2021
avatar bembelimen
bembelimen - comment - 7 Oct 2021

Thx

avatar bembelimen bembelimen - change - 7 Oct 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-10-07 14:31:21
Closed_By bembelimen

Add a Comment

Login with GitHub to post a comment