[#35725] - [4.0] Simplify keepalive.js
- Fixed in Code Base
- 7 Oct 2021
- Medium
- Build: 4.0-dev
- # 35725
- Diff
- dgrammatiko:KeepAlive
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Remove IIFE
- Remove redundant checks
- Switch from XHR to sendBeacon https://developer.mozilla.org/en-US/docs/Web/API/Navigator/sendBeacon
Testing Instructions
Apply the PR
Change the Session Lifetime (minutes) to 1 in Global Configuration -> System
Observe the Other in the network tab of your browser's console
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None, We're switching from XHR to sendBeacon which is widely supported
https://caniuse.com/beacon
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
?
NPM Resource Changed
|
||
@Stuartemk yes all these are correct...
Edit: probably you're totally unaware how Joomla is dealing with the static assets, please read the readme.md: https://github.com/joomla/joomla-cms/tree/4.0-dev/build
Ok
What I saw is the difference that one is es5 and another is es6
I do not understand why, I admit my lack of knowledge, but since I mentioned that and you confirm that it is well I trust.
Simplifying turns out not to simple
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35725.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35725.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35725.
Thx
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-07 14:31:21 |
| Closed_By | ⇒ | bembelimen |
@Stuartemk yes all these are correct...
Edit: probably you're totally unaware how Joomla is dealing with the static assets, please read the readme.md: https://github.com/joomla/joomla-cms/tree/4.0-dev/build