? ? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
2 Oct 2021

Pull Request for Issue #35721 .

Summary of Changes

Fixes incorect name for child subform.

Testing Instructions

Run bpm install
And please follow #35721

Or create a subform somewhere, example in XML for Custom HTML module

<field
        name="subform_parent"
        label="Subform Parent"
        type="subform"
        multiple="true"
        buttons="add,remove"
>
    <form>
        <field
                name="test_text"
                label="Test Text"
                type="text"
        />
        <field
                name="child_subform"
                label="Child Subform"
                type="subform"
                multiple="true"
        >
            <form>
                <field
                        name="child_text"
                        label="Child Field"
                        type="text"
                />
            </form>
        </field>
    </form>
</field>

Add parent field, add children field, and save.

Actual result BEFORE applying this Pull Request

You got 2 parents instead 1

Expected result AFTER applying this Pull Request

All saved correctly

Documentation Changes Required

none

avatar Fedik Fedik - open - 2 Oct 2021
avatar Fedik Fedik - change - 2 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2021
Category JavaScript Repository NPM Change
f4b0dc2 2 Oct 2021 avatar Fedik jscs
avatar Fedik Fedik - change - 2 Oct 2021
Labels Added: ? NPM Resource Changed
avatar DelPoint
DelPoint - comment - 2 Oct 2021

Commit breaks showon functionality on my test box: a field with showon condition validated false (ie. field should not displayed) on the subform is displayed. If this field is a clickable button group (ie. BS style radio button), then they are not clickable.
For more details see #35721

avatar DelPoint
DelPoint - comment - 2 Oct 2021

Modify the above XML example to have a 2nd field with showon condition to test my previous comment:

<field
        name="subform_parent"
        label="Subform Parent"
        type="subform"
        multiple="true"
        buttons="add,remove"
  >
    <form>
        <field
                name="test_text"
                label="Test Text"
                type="text"
        />
        <field
                name="child_subform"
                label="Child Subform"
                type="subform"
                multiple="true"
        >
            <form>
                <field
                        name="child_text"
                        label="Child Field"
                        type="text"
                />
                <!-- Here is the field with showon -->
                <field
                        name="child_text2"
                        label="Child Field2"
                        type="text"
                        showon="child_text!:"
                />

            </form>
        </field>
    </form>
</field>
avatar Fedik
Fedik - comment - 3 Oct 2021

Showon will not work inside nested subfom until first save, that related to how subform and showon works.
It worked by accident, because a bug in subform.
It need to be fixed on "showon" side, but it not an easy one.

Test your original issue.

avatar Fedik
Fedik - comment - 3 Oct 2021

For showon test that PR #35735, but only with current.

avatar dgrammatiko
dgrammatiko - comment - 3 Oct 2021

I have tested this item successfully on f4b0dc2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35726.

avatar dgrammatiko dgrammatiko - test_item - 3 Oct 2021 - Tested successfully
avatar Fedik
Fedik - comment - 3 Oct 2021

@DelPoint Please visit here https://issues.joomla.org/tracker/joomla-cms/35726 and use this button:
image

avatar DelPoint
DelPoint - comment - 3 Oct 2021

I have tested this item successfully on f4b0dc2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35726.

avatar DelPoint DelPoint - test_item - 3 Oct 2021 - Tested successfully
avatar DelPoint
DelPoint - comment - 3 Oct 2021

@Fedik done as you wished. Sorry, didn't know that GitHub approval is not enough (I guess).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35726.

avatar alikon alikon - change - 4 Oct 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 4 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35726.

avatar bembelimen bembelimen - close - 5 Oct 2021
avatar bembelimen bembelimen - merge - 5 Oct 2021
avatar bembelimen bembelimen - change - 5 Oct 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-10-05 14:19:56
Closed_By bembelimen
Labels Added: ?
avatar bembelimen
bembelimen - comment - 5 Oct 2021

Thx

Add a Comment

Login with GitHub to post a comment