RTC PR-4.0-dev hacktoberfest-accepted

Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
2 Oct 2021

Pull Request for Issue #35670 .

Summary of Changes

don't change Created Date

Testing Instructions

  1. Set your server time (System - Global Configuration - Server) to something different from UTC. Testing this is more intuitive, if your server is actually located in this time zone (e.g. CEST = UTC+2). Otherwise, you'd have to do the appropriate calculations in order to check if the time fits.
  2. Check the time zone setting of your own user (top right: User Menu - Edit Account - Basic Settings) to match your actual time zone (or to compensate for the "wrong" server time zone from step 1 if your server is on UTC).
  3. At Components - Tags, create a new tag and save it.
  4. Edit the tag and look at the created and modified date.
  5. Save the tag multiple times.

Actual result BEFORE applying this Pull Request

The Created Date is increased on every save.

Expected result AFTER applying this Pull Request

The Created Date do not change on every save.

Documentation Changes Required

No

avatar alikon alikon - open - 2 Oct 2021
avatar alikon alikon - change - 2 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2021
Category com_tags Administration
avatar ChristineWk
ChristineWk - comment - 2 Oct 2021

I have tested this item successfully on 29007d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35724.

avatar ChristineWk ChristineWk - test_item - 2 Oct 2021 - Tested successfully
avatar jwaisner
jwaisner - comment - 4 Oct 2021

I have tested this item successfully on 29007d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35724.

avatar jwaisner jwaisner - test_item - 4 Oct 2021 - Tested successfully
avatar jwaisner jwaisner - change - 4 Oct 2021
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 4 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35724.

avatar wilsonge wilsonge - change - 17 Oct 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-10-17 16:38:25
Closed_By wilsonge
Labels Added: RTC PR-4.0-dev hacktoberfest-accepted
avatar wilsonge wilsonge - close - 17 Oct 2021
avatar wilsonge wilsonge - merge - 17 Oct 2021
avatar wilsonge
wilsonge - comment - 17 Oct 2021

Thanks!

avatar zero-24
zero-24 - comment - 17 Oct 2021

I have just backported this change to 3.10: #35846 would be great to get some tests there. Thanks!

Add a Comment

Login with GitHub to post a comment