[#35723] - [4.0] Fix showOn for select field with multiple attr
- Fixed in Code Base
- 17 Oct 2021
- Medium
- Build: 4.0-dev
- # 35723
- Diff
- dgrammatiko:4.0-dev_SHOWON
User tests: Successful: Unsuccessful:
Pull Request for Issue #35486 .
Summary of Changes
- Fixes the bug
- Removes the IIFE as the script is a module now
Testing Instructions
- Check the banners config.xml: www/administrator/components/com_banners/config.xml
- The config has the fields save_history (radio) and history_limit (number) showon="save_history:1"
- When you go to the config form, you can enable "Enable Versions" and it shows the "Maximum Versions" associated field
- Change the save_history (radio) to save_history (list), type="list", it still works OK
- Remove the layout to save_history (list), layout="joomla.form.field.radio.switcher", it still works OK
- Add the multiple="true" to the save_history (list), the shown conditional field doesn't work.
Or check #35486 (comment)
Actual result BEFORE applying this Pull Request
Not working
Expected result AFTER applying this Pull Request
Working
Documentation Changes Required
No, bug fix
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
?
NPM Resource Changed
|
||
I have tested this item
It still works OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.
I have tested this item
It works. :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.
I assume, that everyone also tested, that the old behaviour (single field) does not break?
@dgrammatiko if you fix the conflicts, I can merge.
| Labels |
Added:
?
|
||
@bembelimen done
@anibalsanchez could you check that the nonmultiple elements work fine as well?
@dgrammatiko I've been working with the patch and it has worked Ok.
| Status | Ready to Commit | ⇒ | Pending |
still need some changes
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.
| Labels |
Removed:
?
|
||
@anibalsanchez @andreagentil could you revalidate your tests here
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.
It works.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-17 16:45:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 882434a
Test OK!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.