RTC PR-4.0-dev NPM Resource Changed

Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
2 Oct 2021

Pull Request for Issue #35486 .

Summary of Changes

  • Fixes the bug
  • Removes the IIFE as the script is a module now

Testing Instructions

  • Check the banners config.xml: www/administrator/components/com_banners/config.xml
  • The config has the fields save_history (radio) and history_limit (number) showon="save_history:1"
  • When you go to the config form, you can enable "Enable Versions" and it shows the "Maximum Versions" associated field
  • Change the save_history (radio) to save_history (list), type="list", it still works OK
  • Remove the layout to save_history (list), layout="joomla.form.field.radio.switcher", it still works OK
  • Add the multiple="true" to the save_history (list), the shown conditional field doesn't work.

Or check #35486 (comment)

Actual result BEFORE applying this Pull Request

Not working

Expected result AFTER applying this Pull Request

Working

Documentation Changes Required

No, bug fix

avatar dgrammatiko dgrammatiko - open - 2 Oct 2021
avatar dgrammatiko dgrammatiko - change - 2 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2021
Category JavaScript Repository NPM Change
avatar anibalsanchez anibalsanchez - test_item - 2 Oct 2021 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 2 Oct 2021

I have tested this item successfully on 882434a

Test OK!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.

avatar dgrammatiko dgrammatiko - change - 2 Oct 2021
Labels Added: PR-4.0-dev NPM Resource Changed
avatar anibalsanchez anibalsanchez - test_item - 2 Oct 2021 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 2 Oct 2021

I have tested this item successfully on b18a1fe

It still works OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.

avatar andreagentil
andreagentil - comment - 4 Oct 2021

I have tested this item successfully on b18a1fe

It works. :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.

avatar andreagentil andreagentil - test_item - 4 Oct 2021 - Tested successfully
avatar alikon alikon - change - 4 Oct 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 4 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.

avatar bembelimen
bembelimen - comment - 5 Oct 2021

I assume, that everyone also tested, that the old behaviour (single field) does not break?

@dgrammatiko if you fix the conflicts, I can merge.

avatar dgrammatiko dgrammatiko - change - 5 Oct 2021
Labels Added: RTC
avatar dgrammatiko
dgrammatiko - comment - 5 Oct 2021

@bembelimen done
@anibalsanchez could you check that the nonmultiple elements work fine as well?

avatar anibalsanchez
anibalsanchez - comment - 5 Oct 2021

@dgrammatiko I've been working with the patch and it has worked Ok.

avatar Fedik Fedik - change - 7 Oct 2021
Status Ready to Commit Pending
avatar Fedik
Fedik - comment - 7 Oct 2021

still need some changes


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.

28b6eb9 7 Oct 2021 avatar dgrammatiko sync
avatar dgrammatiko dgrammatiko - change - 7 Oct 2021
Labels Removed: RTC
avatar dgrammatiko
dgrammatiko - comment - 7 Oct 2021

@anibalsanchez @andreagentil could you revalidate your tests here

avatar anibalsanchez
anibalsanchez - comment - 8 Oct 2021

I have tested this item successfully on c3c22b6

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.

avatar anibalsanchez anibalsanchez - test_item - 8 Oct 2021 - Tested successfully
avatar andreagentil
andreagentil - comment - 8 Oct 2021

It works.

avatar andreagentil
andreagentil - comment - 8 Oct 2021

I have tested this item successfully on c3c22b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.

avatar andreagentil andreagentil - test_item - 8 Oct 2021 - Tested successfully
avatar RickR2H RickR2H - change - 10 Oct 2021
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 10 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35723.

avatar wilsonge wilsonge - close - 17 Oct 2021
avatar wilsonge wilsonge - merge - 17 Oct 2021
avatar wilsonge wilsonge - change - 17 Oct 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-10-17 16:45:00
Closed_By wilsonge
Labels Added: RTC
avatar wilsonge
wilsonge - comment - 17 Oct 2021

Thanks!

Add a Comment

Login with GitHub to post a comment