Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34922] - [4.0] Media field no preview

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
27 Jul 2021

Pull Request for Issue #34921 .

Summary of Changes

  • pick the right extension regardless of the url (code was only working for local adpters)

Testing Instructions

Test that local files have a preview
Test that remote files have apreview

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@laoneo

avatar dgrammatiko dgrammatiko - open - 27 Jul 2021
avatar dgrammatiko dgrammatiko - change - 27 Jul 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2021
Category ⇒ JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 27 Jul 2021

@dgrammatiko JS linter complains about 2 missing semicolons: https://ci.joomla.org/joomla/joomla-cms/46175/1/21

3502d34 27 Jul 2021 avatar dgrammatiko cs
avatar dgrammatiko dgrammatiko - change - 27 Jul 2021
Labels Added: NPM Resource Changed ?
avatar laoneo
laoneo - comment - 27 Jul 2021

Works ?

avatar richard67
richard67 - comment - 27 Jul 2021

Works ?

@laoneo Then mark your test result in the issue tracker. Thanks in advance.

avatar wilsonge wilsonge - close - 27 Jul 2021
avatar wilsonge wilsonge - merge - 27 Jul 2021
avatar wilsonge wilsonge - change - 27 Jul 2021
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-07-27 18:07:06
Closed_By ⇒ wilsonge
avatar wilsonge
wilsonge - comment - 27 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment