Joomla! Issue Tracker | Joomla! CMS #34921 - [4.0] Media field preview shows no image when url has no extension

Closed
27 Jul 2021
Medium
Build: staging
# 34921

laoneo
27 Jul 2021

When adding a url into the image field of an article which has no extension, then the preview image is not rendered. This is the case for example with google drive which creates urls like https://drive.google.com/uc?id=dr123&export=download.

Issue appears since #34634.

@dgrammatiko any idea?

laoneo - open - 27 Jul 2021

joomla-cms-bot - change - 27 Jul 2021

Labels

Added: ?

joomla-cms-bot - labeled - 27 Jul 2021

laoneo - change - 27 Jul 2021

The description was changed

laoneo - edited - 27 Jul 2021

dgrammatiko - comment - 27 Jul 2021

Might be

joomla-cms/build/media_source/system/js/fields/joomla-field-media.w-c.es6.js

Line 212 in caf4cb7

    
           previewElement.src = /http/.test(value) ? value : Joomla.getOptions('system.paths').rootFull + value;

Check what the value is there (maybe you have to remove the hash part of the url)

laoneo - comment - 27 Jul 2021

Problem is that the extension can't be determined here

joomla-cms/build/media_source/system/js/fields/joomla-field-media.w-c.es6.js

Line 200 in caf4cb7

const ext = getExtension(value);

so it will not even arrive on 212.

dgrammatiko - comment - 27 Jul 2021

@laoneo pass me some some valid URL in DM (tweeter or whatever)

dgrammatiko - comment - 27 Jul 2021

@laoneo this should do it:

const getExtension = (path) => {
  const parts = path.split(/[#]/);
  if (parts.length) {
    const clean = parts[1].split(/[\?]/);
     return clean[0].split('.').pop().trim()
  }
  return path.split(/[#?]/)[0].split('.').pop().trim();
}

laoneo - comment - 27 Jul 2021

It does, do you make a pr?

dgrammatiko - comment - 27 Jul 2021

sure

dgrammatiko - comment - 27 Jul 2021

@laoneo done: #34922

richard67 - close - 27 Jul 2021

richard67 - comment - 27 Jul 2021

Closing as having a pull request. Please test #34922 . Thanks in advance.

richard67 - change - 27 Jul 2021

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2021-07-27 10:24:10
Closed_By		⇒	richard67

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#34921] - [4.0] Media field preview shows no image when url has no extension

Add a Comment