Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34923] - [4.0] Atum: Changing hue value, module-position-colour stay same

? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar pinak3748
pinak3748
27 Jul 2021

Summary of Changes

This is issue #34307

What needs to be fixed

Go to System> Administrator Template Styles and change the hue value for the dark template colour (i used 89).

In modules the position-colour stay same:

image

Why this should be fixed

At Menu (multilingual site) the colour change.

Changed template style Default template style
image image

Expected result AFTER applying this Pull Request

aaa

avatar pinak3748 pinak3748 - open - 27 Jul 2021
avatar pinak3748 pinak3748 - change - 27 Jul 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2021
Category ⇒ Administration com_content com_modules com_tags Front End
avatar pinak3748 pinak3748 - change - 27 Jul 2021
Title
…
4.0 dev
4.0 dev Atum: Changing hue value, module-position-colour stay same
avatar pinak3748 pinak3748 - edited - 27 Jul 2021
avatar richard67 richard67 - change - 27 Jul 2021
Title
…
4.0 dev Atum: Changing hue value, module-position-colour stay same
[4.0] Atum: Changing hue value, module-position-colour stay same
avatar richard67 richard67 - edited - 27 Jul 2021
avatar drmenzelit
drmenzelit - comment - 27 Jul 2021

Hi @pinak3748 , thank you for your contribution. Please check the Bootstrap documentation for badges: https://getbootstrap.com/docs/5.0/components/badge/
In your PR you are mixing badge and btn classes.

avatar pinak3748 pinak3748 - change - 27 Jul 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2021
Category Administration com_content com_modules com_tags Front End ⇒ Administration com_content com_modules Templates (admin) NPM Change
avatar pinak3748
pinak3748 - comment - 28 Jul 2021

Thanks for letting me @drmenzelit know I have made the changes without using buttons or badges

avatar pinak3748
pinak3748 - comment - 29 Jul 2021

@brianteeman Can you review and test my changes

avatar pinak3748
pinak3748 - comment - 1 Aug 2021

Can someone please test changes on #34923

avatar drmenzelit
drmenzelit - comment - 1 Aug 2021

@pinak3748 please be patient... I checked the code, but not tested the PR. You are now giving all badges a background colour, that seems wrong to me. Have you checked for side effects? What happen to other badges in the backend?

avatar pinak3748 pinak3748 - change - 2 Aug 2021
Labels Added: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2021
Category Administration com_content com_modules Templates (admin) NPM Change ⇒ Administration com_content com_finder com_modules com_tags Templates (admin) NPM Change
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2021
Category Administration com_content com_modules Templates (admin) NPM Change com_finder com_tags ⇒ Administration com_content com_modules Templates (admin) NPM Change
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2021
Category Administration com_content com_modules Templates (admin) NPM Change ⇒ Administration com_content com_finder com_menus com_modules com_tags Templates (admin) NPM Change
avatar pinak3748
pinak3748 - comment - 6 Aug 2021

I have checked this in all cases but I think I misss the object of the issue and created a new one along that way and my approach is wrong so that's why I am closing this issue.

avatar pinak3748 pinak3748 - change - 6 Aug 2021
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-08-06 12:41:37
Closed_By ⇒ pinak3748
Labels
avatar pinak3748 pinak3748 - close - 6 Aug 2021

Add a Comment

Login with GitHub to post a comment