NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
27 Jul 2021

Pull Request as a supplementary to #34885

Summary of Changes

  • adds a hash to the thumb and the preview image URLs
  • The hash is generated once in the app's lifecycle (efficient)

Testing Instructions

This relies on #34885 so if it's not already merged you need to apply that code first

Also, you need to set expire headers in your NginX (or Apache or whatever you're using) so the browser could cache files for some given period (eg 1 year)

Edit a file and check that the media manager displays the edited version!

Also, check the media manager's source code

Screenshot 2021-07-27 at 12 43 40

Screenshot 2021-07-27 at 12 43 57

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

No. Joomla SHOULD cache (and invalidate) all the static assets.
The media manager team had some plans for a db layer but that was never implemented. Something needs to be done in the direction of storing/retrieving related data, both for cache invalidation but most importantly for the external adapters...
I know cache invalidation is hard but the project should try to fix the fundamentals before going to fancy things like Responsive Images with Art Direction which by the way has a number of architectural flaws...

avatar dgrammatiko dgrammatiko - open - 27 Jul 2021
avatar dgrammatiko dgrammatiko - change - 27 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2021
Category JavaScript Administration com_media NPM Change
avatar richard67
richard67 - comment - 27 Jul 2021

@dgrammatiko JS linter complains about missing comma: https://ci.joomla.org/joomla/joomla-cms/46179/1/21

3e393d0 27 Jul 2021 avatar wilsonge JSCS
avatar wilsonge wilsonge - change - 27 Jul 2021
Labels Added: NPM Resource Changed ?
avatar dgrammatiko
dgrammatiko - comment - 27 Jul 2021

@richard67 obviously not my day today, going to do some gardening ?‍?

avatar richard67
richard67 - comment - 27 Jul 2021

... fancy things like Responsive Images with Art Direction which by the way has a number of architectural flaws...

@dgrammatiko Please report such things in that PR #34803 .

avatar dgrammatiko
dgrammatiko - comment - 27 Jul 2021

@dgrammatiko Please report such things in that PR #34803 .

My point is that there are FUNDAMENTAL unresolved issues with the media manager, as it was never completed by the team that build it in the first place. These issues should be fixed before adding functionality that already many 3rd pd offer freely...

avatar richard67
richard67 - comment - 27 Jul 2021

My point is that there are FUNDAMENTAL unresolved issues with the media manager, as it was never completed by the team that build it in the first place. These issues should be fixed before adding functionality that already many 3rd pd offer freely...

@dgrammatiko I see. Do we have these issues already reported somewhere?

avatar dgrammatiko dgrammatiko - change - 27 Jul 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 27 Jul 2021
avatar dgrammatiko
dgrammatiko - comment - 27 Jul 2021

@dgrammatiko I see. Do we have these issues already reported somewhere?

I don't but maybe @laoneo has the list of the todos for version 2 (or whatever we called the second iteration) of media manager

a8b5bec 27 Jul 2021 avatar dgrammatiko pfff
avatar wilsonge wilsonge - change - 27 Jul 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-27 17:40:44
Closed_By wilsonge
avatar wilsonge wilsonge - close - 27 Jul 2021
avatar wilsonge wilsonge - merge - 27 Jul 2021
avatar wilsonge
wilsonge - comment - 27 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment