NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
14 May 2021

Pull Request for Issue #33754 (comment) and #34105

Summary of Changes

Joomla logo is expanded pushing the cog icon out of view and toolbar options are displayed by default.

Testing Instructions

Shrink the width of your browser to a mobile width and open the menu/toolbar. The logo should not expand

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 14 May 2021
avatar dgrammatiko dgrammatiko - change - 14 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category JavaScript Repository NPM Change
avatar Quy
Quy - comment - 14 May 2021

It is fine/collapsed on the Home Dashboard initially, but going to other sections such as Articles list, it expands again.

avatar RickR2H
RickR2H - comment - 16 May 2021

When I do a refresh in Chrome with the mobile view active, the logo is initially expanded. When I resize the mobile window just a little bit, the logo shrinks and everything jumps into place. When I do a refresh again the logo is back to its initial expanded state.

f12daae 16 May 2021 avatar dgrammatiko logo
a5b1776 22 May 2021 avatar dgrammatiko a
avatar dgrammatiko dgrammatiko - change - 22 May 2021
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2021
Category JavaScript Repository NPM Change Administration Templates (admin) JavaScript Repository NPM Change
avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

Is this animation by design? its annoying haha

Screen.Recording.2021-05-23.at.09.45.19.am.mp4
avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

only other thing - which I dont think is related to this PR is

On mobile, navigate to the User Action Log page
Click bottom right corner to launch menu
Note the menu is open - correct
Note you cannot get to HomeDashboard by scrolling - broken, but probably ok as you can collapse the open Users menu to see it. (Home Dashboard is off screen, and you cannot scroll to is, you have to collapse the open menu leaf to get to it)

avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

When I do a refresh in Chrome with the mobile view active, the logo is initially expanded. When I resize the mobile window just a little bit, the logo shrinks and everything jumps into place. When I do a refresh again the logo is back to its initial expanded state.

I cannot replicate this today. On a real mobile.

avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

It is fine/collapsed on the Home Dashboard initially, but going to other sections such as Articles list, it expands again.

I cannot replicate this today.

avatar PhilETaylor PhilETaylor - test_item - 23 May 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

I have tested this item successfully on b0d82e0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33877.

avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

When I resize the mobile window

What I will say, is that the web is meant to be browsed not squished.

You are correct that there are some issues that a refresh of the page fixes, however its very rare to resize from a desktop view to a mobile view and back to a desktop view without refreshing and so testing that is not really a valid test I dont believe.

Screen.Recording.2021-05-23.at.10.05.43.am.mp4
avatar dgrammatiko
dgrammatiko - comment - 23 May 2021

What I will say, is that the web is meant to be browsed, not squished.

There are still assumptions with the current code, especially for the transition to mobile or going from mobile to desktop.

Could we tackle those?

Probably yes by transforming the cookie value to a JSON string (store state for logo, menu state and header toolbar), but I see little advantage to complicate further the code to iron out a couple of glitches which are edge cases (e.g. clicking on the save button on mobile view will not reload the page with the toolbar open). There are trade-offs (perf vs covering all cases), and as is the script is not very efficient/performant, and my whole approach here was to eliminate as much as possible the annoying open/close animations on page reload and not to re-architecture the way we put together those underlaying parts

avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

however its very rare to resize from a desktop view to a mobile view and back to a desktop view without refreshing and so testing that is not really a valid test I dont believe.

^^ thats my way of saying I agree with you, its a non-issue at this stage. If you are going to rotate a mobile device from landscape to portrait and back again I dont expect a website to handle that perfectly, even in 2021, and its no harm to refresh.

avatar dgrammatiko dgrammatiko - change - 23 May 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 23 May 2021
avatar Quy Quy - test_item - 28 May 2021 - Tested successfully
avatar Quy
Quy - comment - 28 May 2021

I have tested this item successfully on cdfbb5f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33877.

avatar PhilETaylor PhilETaylor - test_item - 1 Jun 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 1 Jun 2021

I have tested this item successfully on cdfbb5f

A quick test as I tested intensively previously


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33877.

avatar Quy Quy - change - 1 Jun 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33877.

avatar chmst chmst - change - 10 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-10 18:05:25
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 10 Jun 2021
avatar chmst chmst - merge - 10 Jun 2021
avatar chmst
chmst - comment - 10 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment