[#33878] - [4.0] [Banners] One button for similar actions
- Fixed in Code Base
- 15 May 2021
- Medium
- Build: 4.0-dev
- # 33878
- Diff
- Kostelano:4.0-reset-but
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
PR improves the display of reset buttons in the Banners component (see screenshot) + adds a constant that can be used in the future for similar actions.
BEFORE / AFTER
Testing Instructions
Go to the banners component and create a new banner. On the second tab, pay attention to the reset buttons.
Documentation Changes Required
Not
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33878.
@brianteeman Do I assume right that the change made by this PR here is ok regarding a11y because the buttons have aria-hidden="true" so a screen reader won't read them anyway?
aria-hidden="true" applies to the icon and not the button.
Oh, then maybe someone really should check with a screen reader.
Changing to just say reset is no different to similar fields where we have create/edit
But you don't need to keep asking me for accessibility issues you can ask the accessibility team
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33878.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-15 16:29:36 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thank you!
I have tested this item✅ successfully on d8d42ee
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33878.