[#33879] - [4] Move check for offline mode from render to dispatch so that modules are not rendered on 403
- Closed
- 7 Mar 2022
- Medium
- Build: 4.0-dev
- # 33879
- Diff
- PhilETaylor:offline
User tests: Successful: Unsuccessful:
Closes #29455
Summary of Changes
Move check for offline mode from render to dispatch method so that modules are not rendered on 403
Testing Instructions
Set your Joomla 4 site to offline mode in Joomla global config
Visit the frontend.
Attempt to login as admin - you can - great - you can see the site - great.
Attempt to go to https://example.com/index.php/component/config = 403 Error (Some module positions will render like headers and footers and maybe menus depending on your template
Apply PR, repeat test, this time at https://example.com/index.php/component/config you will get a login box.
Actual result BEFORE applying this Pull Request
Attempt to go to https://example.com/index.php/component/config = 403 Error (Some module positions will render like headers and footers and maybe menus depending on your template
Expected result AFTER applying this Pull Request
this time at https://example.com/index.php/component/config you will get a login box. You can login to see your site
Also
Cleans up two unused language vars.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
With or without the patch I don't get 403 - just the Home page (multilingual site).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33879.
localhost/j4test/index.php/component/config/
but reloads as http://localhost/j4test/index.php/en/
also used https - Macbook Pro with Cataline / PHP8 / ... merged latest commits early this morning.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33879.
this just means your language redirects are kicking in before this PRs code, which is not a bad thing
What if you start at http://localhost/j4test/index.php/en/component/config/ - please run your testing starting at that url.
http://localhost/j4test/index.php/en/component/config/ gives me a 403 page with Banner, Top menu and Footer with Login. I also get an error call stack:
403 You don't have permission to access this. Please contact a website administrator if this is incorrect.
JROOT/components/com_config/src/Dispatcher/Dispatcher.php:50
with and without the patch applied
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33879.
That last comment was wrong - I forgot to go off-line again. Actual result is as before.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33879.
So what you are saying is that yours was a successful test, when a site is multi-lingual, that you cannot replicate the issue this PR resolves, and your testing showed that this PR did not make your experience, with a multi-lingual site any worse.
Yes - I cannot reproduce the problem described on my multi-lingual test site. I do not get a 403 page.
The successfully test above was on a multilanguage site.
I've been test now using index.php/de/component/config (+ fr, fa), always successfully.
DO NOT TEST on a multi-lingual site. That never had the issue to start with, so this PR doesn't solve anything on a multi-lingual site.
All your tests prove on a multi-lingual site is that I did not break anything further.
Please try to replicate the reported issue. Replicate the issue, Apply the PR, repeat, and see the issue is resolved.
Please try to replicate the reported issue. Replicate the issue, Apply the PR, repeat, and see the issue is resolved.
That's what i have done.
I was not aware to not test on a multilang site, sorry.
| Labels |
Added:
?
|
||
I had the issue on the multilanguage site. That's the first thing i do: do i understand the issue, can i replicate it. Then i test the pull request, the test was successfully.
@PhilETaylor could you please resolve conflicts?
| Labels |
Added:
Conflicting Files
?
Removed: ? |
||
@PhilETaylor could you please resolve conflicts?
There are no conflicts that I can see to resolve. I have merged the upstream branch for the second time.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:33:34 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Removed:
Conflicting Files
|
||
I have tested this item✅ successfully on 3964cc9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33879.