? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
14 May 2021

Closes #26269

Summary of Changes

Fix blatantly wrong code.

If connecting to redis using a sock Eg: /var/run/redis/redis.sock then Joomla should be transparently setting the port to 0 before connecting to redis.

$host[0] === '/' is checking if the first char in the string /var/run/redis/redis.sock is a / and if so should be setting the port to 0 - someone got the ?: wrong the wrong way and no one noticed :)

Testing Instructions

Provision a redis server correctly set up for socket connections though, say, /var/run/redis/redis.sock

Configure Joomla Global configuration to use Redis as a cache and session handler using the above sock (to match your server, not exactly the example /var/run/redis/redis.sock)

Actual result BEFORE applying this Pull Request

Joomla could not connect to redis over sock and would red screen of death or debugger message if debug mode on

Screenshot 2021-05-14 at 20 53 38

Expected result AFTER applying this Pull Request

Joomla can now connect.

Documentation Changes Required

Paging @simbus82 @csthomas

avatar PhilETaylor PhilETaylor - open - 14 May 2021
avatar PhilETaylor PhilETaylor - change - 14 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category Libraries
avatar PhilETaylor PhilETaylor - change - 14 May 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 14 May 2021
avatar PhilETaylor PhilETaylor - change - 14 May 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 14 May 2021
avatar PhilETaylor PhilETaylor - change - 14 May 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 14 May 2021
avatar wilsonge wilsonge - change - 19 May 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-19 22:40:39
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 19 May 2021
avatar wilsonge wilsonge - merge - 19 May 2021
avatar wilsonge
wilsonge - comment - 19 May 2021

Thanks!

avatar simbus82
simbus82 - comment - 20 May 2021

Thank you @PhilETaylor! Wow, i opened the issue 2 years ago...
PS: ehm, what's the meaning of "Paging" under Documentation?

avatar PhilETaylor
PhilETaylor - comment - 20 May 2021

Paging - as in the 1980s term for alerting someone with a pager device. The precursor to text messages on mobile phones.

A friendly way of getting your attention so that you come and review and test this PR.

Pager-in-hand-1280x720

Add a Comment

Login with GitHub to post a comment