[#33743] - [4.0] Install from web: style of error change
- Fixed in Code Base
- 31 May 2021
- Medium
- Build: 4.0-dev
- # 33743
- Diff
- rjharishabh:web-load-error
User tests: Successful: Unsuccessful:
Pull Request for Issue #33680 .
Summary of Changes
Change error style according to Joomla
Testing Instructions
Please disconnect your computer from internet for few seconds
Dashboard > System > Extensions under Install > Go to Install from Web
Apply PR
Do npm i
Repeat above steps and see the difference
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
| Category | Front End Plugins | ⇒ | JavaScript Repository NPM Change Front End Plugins |
| Labels |
Added:
NPM Resource Changed
|
||
@rjharishabh can you please check the comments from @dgrammatiko , I think you didn't make all the changes he was asking for
Done
@rjharishabh Don't get error message
Site File No Problems 4.0.0-2021-05-07 4.0.0-beta8-dev+pr.33743 <hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/33743">issues.joomla.org/tracker/joomla-cms/33743</a>.</sub>
@ChristineWk you misunderstood the testing instructions. Do not take the site offline but rather disconnect your computer from the internet...
Aha :-) also no error message.
after 2nd attempt was then frozen screen
Sorry about.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33743.
See:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33743.
I disconnected my computer from the internet but as i have the installation over launch.joomla.org i can't test ;-)
I have tested this item
I am working on a Mac laptop and at the top of the screen there is a WiFi button with On/Off options. With the patch applied the error message is styled as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33743.
I have tested this item
After PR:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33743.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33743.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-31 08:01:17 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@rjharishabh can you please check the comments from @dgrammatiko , I think you didn't make all the changes he was asking for