[#33744] - [4.0] Remove edit button in toolbar
- Fixed in Code Base
- 10 May 2021
- Medium
- Build: 4.0-dev
- # 33744
- Diff
- Quy:edit-update-sites
User tests: Successful: Unsuccessful:
Summary of Changes
The Edit button in the toolbar implies that multiple items can be edit. This is not the case so remove it. Also this is consistent with other views.
Testing Instructions
System > Update > Update Sites
Select multiple items.
Click the Edit button.
Only the first selected item is editable.
Apply PR.
No Edit button.
Click on an item to edit.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33744.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33744.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-10 19:47:27 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
Thanks
Sorry to be late to the party but this PR is plainly wrong and should be reverted.
Update Sites should be editable. This is how 3rd part extensions allow download ID's to be put in place.
@PhilETaylor This PR here was to have the button in the tool bar because that would mean you can select multiple update sites and edit them, but that dowsn't work. You can edit only one of them at once, and that still is possible by clicking the item title.
If you think that the location of the update site should be editable, too, and not only any secret key, then please check and comment #33460 so that can be re-opened maybe.
The location of the update site (The actual URL) should not be editable - that is provided by the developer in the XML and is for information only.
you can select multiple update sites and edit them
Its a list view, the edit button is only enabled when one or more checkboxes is selected. If more than one checkboxes is selected and then you press edit you should get an error (thats what needs fixing!)
Actually, looks like I did not get the memo... looks like the edit.list button has been removed throughout Joomla... never mind, I'll crawl back into my shell :)
So yeah, all good - sorry.
Haven't checked but I believe we can still click on the link directly to edit update site.
@joomdonation I had checked that when I had set RTC, and it worked.
I have tested this item✅ successfully on e31de48
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33744.