[#33742] - Help scroll top
- Fixed in Code Base
- 14 May 2021
- Medium
- Build: 4.0-dev
- # 33742
- Diff
- ceford:help_scroll_top
User tests: Successful: Unsuccessful:
Pull Request for Issue #33722 .
Summary of Changes
Added Javascript to scroll window to top on selection of Help page
Testing Instructions
Go to Administrator / Help / Start Here - Joomla! Help
Scroll down to near the bottom of the long list and click an item there
Apply patch and rebuild with npm ci
Actual result BEFORE applying this Pull Request
Something should happen, but
Nothing appears to happen because the Iframe with the new help page has been loaded out of sight.
Expected result AFTER applying this Pull Request
The page will scroll to top bringing the newly loaded Help page into view.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Labels |
Added:
?
|
||
| Category | Administration com_admin | ⇒ | Administration com_admin Repository NPM Change JavaScript |
So I moved the javascript to a file and am now looking at the build errors - not ready to retest.
So I moved the javascript to a file and am now looking at the build errors - not ready to retest.
@ceford just use the snippet from #33742 (comment) should be CI friendly
| Labels |
Added:
NPM Resource Changed
|
||
@dgrammatiko Thanks for the snippet - used that and now waiting for the checks to finish.
used that and now waiting for the checks to finish.
You need an empty line at the end
one more change window.scroll(0,0); to window.scroll(0, 0);
I have tested this item
Note test instruction: rebuild js with npm ci
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33742.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33742.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33742.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33742.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-14 09:47:41 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 5348ac5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33742.