Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33487] - [4.0] Make check for package ID or extension ID type safe in pre-update-check javascript

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
2 May 2021

Pull Request for Issue #33477 (part) .

Summary of Changes

  • Use parseInt to get values from data-extension-id and the package_id and extension_id properties of the particular non-core extension object.
  • Let the parseInt from data-extension-id default to zero in order not to match with NaN in later type safe comparison.
  • Use type safe comparison to compare the value from data-extension-id with the package_id and the extension_id properties of the non-core extension.

Testing Instructions

Will be added soon.

Actual result BEFORE applying this Pull Request

The pre-update check works more or less in the 4.0-dev branch after the recent upmerge from 3.10-dev.

The javascript cs in drone fails due to type safe comparison being required.

Expected result AFTER applying this Pull Request

The pre-update check works as well or bad as without this PR.

The javascript cs in drone passes.

Documentation Changes Required

None.

Question

@zero-24 @wilsonge Should that be done in 3.10-dev, too?

avatar richard67 richard67 - open - 2 May 2021
avatar richard67 richard67 - change - 2 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2021
Category ⇒ JavaScript Repository NPM Change
avatar richard67 richard67 - change - 2 May 2021
Labels Added: NPM Resource Changed ?
avatar richard67 richard67 - change - 2 May 2021
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-02 14:47:28
Closed_By ⇒ richard67
avatar richard67 richard67 - close - 2 May 2021

Add a Comment

Login with GitHub to post a comment