NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
2 May 2021

Pull Request for Issue # .

Summary of Changes

There are currently many js errors in com_joomlaupdate. This PR attempts to fix this.

Testing Instructions

I'm unsure as I don't understand fully how pre-update checks in com_joomlaupdate works yet. Maybe for now, code review would be enough because the current code is already broken.

avatar joomdonation joomdonation - open - 2 May 2021
avatar joomdonation joomdonation - change - 2 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2021
Category Administration com_joomlaupdate JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 2 May 2021
78738f7 2 May 2021 avatar joomdonation CS
avatar joomdonation joomdonation - change - 2 May 2021
Labels Added: NPM Resource Changed ?
7fabb21 2 May 2021 avatar joomdonation CS
971d29d 3 May 2021 avatar joomdonation CS
avatar joomdonation
joomdonation - comment - 3 May 2021

@wilsonge As of right now, all the errors are fixed and I would say that it works in the same way with what we are having on 3.10.0. You can review the code and get it merged (I made basic test by installing older version of Akeeba Backup and JCE editor for testing)

However, there are still some problems:

Basically, from what I understand, the loop over all the none core plugins and if that plugin belong to an extension, remove it from the array. But that could cause all plugins load being checked (causes by the removal mentioned). Maybe you can ask the developer who worked on the feature to take a look at it.

avatar dgrammatiko
dgrammatiko - comment - 3 May 2021

However, there are still some problems:

George had asked me to fix this after the BS js PR but I never made a PR because my solution (SPA basically)was touching the restore.php and that wasn't a discussion I wanted myself involved. This is (I think) the repo: https://github.com/joomla/joomla-cms/compare/4.0-dev...dgrammatiko:4.0-dev_joomlaUpdate?expand=1

At the very least check the changes in the controller and the way I pass data from PHP to JS. The current state is god awful...

avatar joomdonation
joomdonation - comment - 3 May 2021

@dgrammatiko I haven't spent time to read the whole code to understand the process, so I could not comment on your solution right now. However, if you make a PR, I would be happy to review and test it. The current code is not looking good, I agree.

0dc7083 3 May 2021 avatar joomdonation CS
826126a 3 May 2021 avatar joomdonation CS
avatar wilsonge
wilsonge - comment - 3 May 2021

Starting to look better. Thanks for fixing my mess trying to port this!

2cd80b5 4 May 2021 avatar joomdonation CS
avatar wilsonge wilsonge - change - 6 May 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-06 08:00:17
Closed_By wilsonge
avatar wilsonge wilsonge - close - 6 May 2021
avatar wilsonge wilsonge - merge - 6 May 2021
avatar wilsonge
wilsonge - comment - 6 May 2021

This is clearly an improvement merging this now

Add a Comment

Login with GitHub to post a comment