? ? Pending

User tests: Successful: Unsuccessful:

avatar YatharthVyas
YatharthVyas
2 May 2021

Summary of Changes

Similar to PR #33469
Removes cellspacing and cellpadding from the Error Backtrace Table
This was the only remaining occurrence of these deprecated attributes. Ran a global search with my IDE and couldn't find any other place where either of these was used.

Testing Instructions

Visit any invalid view in backend like:
/administrator/index.php?option=com_content&view=articles1
and use inspect element (Devtools) to ensure that the deprecated attributes are removed and the view is not affected

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

None

avatar YatharthVyas YatharthVyas - open - 2 May 2021
avatar YatharthVyas YatharthVyas - change - 2 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2021
Category Layout
avatar PhilETaylor PhilETaylor - test_item - 2 May 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 2 May 2021

I have tested this item successfully on 37f2ea4

Drone error unrelated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33486.

avatar Quy Quy - test_item - 2 May 2021 - Tested successfully
avatar Quy
Quy - comment - 2 May 2021

I have tested this item successfully on 37f2ea4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33486.

avatar Quy Quy - change - 2 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 2 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33486.

avatar richard67 richard67 - change - 2 May 2021
Labels Added: ?
avatar richard67 richard67 - alter_testresult - 2 May 2021 - PhilETaylor: Tested successfully
avatar richard67 richard67 - alter_testresult - 2 May 2021 - Quy: Tested successfully
avatar richard67
richard67 - comment - 2 May 2021

I've updated the branch to latest 4.0-dev to get rid of the unrelated javascript-cs error in drone and restored the previous test results in the issue tracker.

avatar richard67 richard67 - change - 2 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-02 19:22:30
Closed_By richard67
Labels Added: ?
Removed: ?
avatar richard67 richard67 - close - 2 May 2021
avatar richard67 richard67 - merge - 2 May 2021
avatar richard67
richard67 - comment - 2 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment