[#33485] - [4.0] Validation in Mass Mail Users
- Closed
- 19 Aug 2021
- Medium
- Build: 4.0-dev
- # 33485
- Diff
- rjharishabh:mass-mail
User tests: Successful: Unsuccessful:
Pull Request for Issue #33450
Summary of Changes
form-validation added
Testing Instructions
Users > Mass Mail Users > Click Send Email
Apply PR
npm i
Repeat and See the changes
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration com_users JavaScript Repository NPM Change | ⇒ | Administration com_users Language & Strings JavaScript Repository NPM Change |
| Labels |
Added:
?
|
||
I've updated the branch to latest 4.0-dev to get rid of the unrelated javascript-cs error in drone.
I tested your PR and it works as mentioned. Great Work @rjharishabh!
However, I noticed that a very similar form exists for Private Messages where The Subject and the Message is validated. Here, the validation prompt is displayed in a slightly different style with the list of all the fields having an error:
An improvement suggestion: such an implementation can provide better UX feedback to the user and it will also maintain consistency among the mail/message component forms. What's your opinion?
I will look into it
I agree with @YatharthVyas. However, the PR works well.
I have tested this item
The individual fields work but the form submits with the subject and message fields both empty. Is that was what the javascript file was for?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33485.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-19 12:08:43 |
| Closed_By | ⇒ | rjharishabh | |
| Labels |
Added:
Language Change
?
?
Removed: ? ? |
||
Is there a need for the JavaScript file as validation is no longer done in it?