NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
2 Jan 2021

Pull Request for Issue #31820 and #29156 .

Summary of Changes

Currently rotating and resizing an image let the box jump, based on the height. This PR moves the image below the parameters so there is no jumping.

Testing Instructions

Edit an image in the media manager

Actual result BEFORE applying this Pull Request

Jumping because the image is above the parameters

Expected result AFTER applying this Pull Request

No jumping because the image is below the parameters.

avatar bembelimen bembelimen - open - 2 Jan 2021
avatar bembelimen bembelimen - change - 2 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jan 2021
Category Administration com_media JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 2 Jan 2021

I have tested this item successfully on 94750c3

Hint for other testers: It needs NPM to build the JS.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31830.

avatar richard67 richard67 - test_item - 2 Jan 2021 - Tested successfully
avatar ceford
ceford - comment - 2 Jan 2021

I have tested this item successfully on 94750c3

Yes - I prefer it this way.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31830.

avatar ceford ceford - test_item - 2 Jan 2021 - Tested successfully
avatar richard67 richard67 - change - 2 Jan 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31830.

avatar richard67 richard67 - change - 2 Jan 2021
Labels Added: ? ? NPM Resource Changed
avatar PhocaCz
PhocaCz - comment - 2 Jan 2021

I have tested this item successfully on 94750c3

img


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31830.

avatar PhocaCz PhocaCz - test_item - 2 Jan 2021 - Tested successfully
avatar drmenzelit drmenzelit - change - 2 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-02 14:41:03
Closed_By drmenzelit
Labels
avatar drmenzelit drmenzelit - close - 2 Jan 2021
avatar drmenzelit drmenzelit - merge - 2 Jan 2021
avatar drmenzelit
drmenzelit - comment - 2 Jan 2021

Thanks

Add a Comment

Login with GitHub to post a comment