Feeling Lucky
?
?
[#31831] - [4.0] Fix width in com_modules batch position select
- Fixed in Code Base
- 2 Jan 2021
- Medium
- Build: 4.0-dev
- # 31831
- Diff
- bembelimen:4.0/29910
User tests: Successful: Unsuccessful:
Pull Request for Issue #29910 .
Summary of Changes
Fix the width of the position select in modules batch
Testing Instructions
Check the batch in com_modules
Actual result BEFORE applying this Pull Request
Select for positon is small
Expected result AFTER applying this Pull Request
Select for positon is 100%
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
infograf768
- comment
- 2 Jan 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31831.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 2 Jan 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31831.
| Labels |
Added:
?
?
|
||
infograf768
- comment
- 2 Jan 2021
This indeed does the job in the description and that's why I tested it OK.
But I think we have a UX issue here.
We should have a - Keep Original Position - display when we use the small x to kill the :: None :: option.
In fact it should be the default and not :: None ::
I mean when we empty the input field.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-02 20:38:36 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
wilsonge
- comment
- 2 Jan 2021
@infograf768 id agree with that. You able to do the patch?
I have tested this item✅ successfully on 4e92ad6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31831.