? ? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
2 Jan 2021

Pull Request for Issue #29550 .

Summary of Changes

Rename text in system dashboard

Testing Instructions

Go to system dashboard

Actual result BEFORE applying this Pull Request

"Levels"

Expected result AFTER applying this Pull Request

"Access Levels"

avatar bembelimen bembelimen - open - 2 Jan 2021
avatar bembelimen bembelimen - change - 2 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jan 2021
Category Administration com_menus Language & Strings
avatar brianteeman
brianteeman - comment - 2 Jan 2021

This is not such a simple solution. Unfortunately we have at least three different terms being used for the same thing.

avatar richard67
richard67 - comment - 2 Jan 2021

I can confirm that this PR solves issue #29550 according to its description, i.e. the menu item title in the system dashboard is consistent with the one in the users dashboard and the left side navigation menu.

But when following that menu item, the title of the page isn't consistent with the menu item title in the left side menu, see green and red marks in the following screenshot:

j4-pr31832_3

There are more places where we use "Viewing Access Level":

richard@vmkubu02:~/lamp/public_html/joomla-cms-4.0-dev$ find ./ -type f -name "*\.ini" -exec grep -iHn "viewing access level" {} \;
./administrator/language/en-GB/com_users.ini:174:COM_USERS_LEVELS_TABLE_CAPTION="Table of Viewing Access Levels"
./administrator/language/en-GB/com_users.ini:224:COM_USERS_NO_LEVELS_SELECTED="No Viewing Access Levels selected."
./administrator/language/en-GB/com_users.ini:264:COM_USERS_SEARCH_ACCESS_LEVELS="Search Viewing Access Levels"
./administrator/language/en-GB/com_users.ini:278:COM_USERS_SUBMENU_LEVELS="Viewing Access Levels"
./administrator/language/en-GB/com_users.ini:335:COM_USERS_VIEW_EDIT_LEVEL_TITLE="Users: Edit Viewing Access Level"
./administrator/language/en-GB/com_users.ini:339:COM_USERS_VIEW_LEVELS_TITLE="Users: Viewing Access Levels"
./administrator/language/en-GB/com_users.ini:341:COM_USERS_VIEW_NEW_LEVEL_TITLE="Users: New Viewing Access Level"
richard@vmkubu02:~/lamp/public_html/joomla-cms-4.0-dev$

I think we should consistently use either "Access Level" or "Viewing Access Level" wherever possible (but the latter could be a bit long).

So I agree with @brianteeman that there is more to be cleaned up.

@bembelimen Do you want to fix that with this PR here? Or shall it be done with another PR?

The column title "Level Name" (see orange marks in the above screenshot) are ok in this context, I think.

avatar ceford
ceford - comment - 2 Jan 2021

Looked at this with and without patch. For me it is the word Viewing that makes me scratch my head. What does it mean (rhetorical). Could it be left out?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31832.

avatar brianteeman
brianteeman - comment - 2 Jan 2021

@richard67 a long time ago I tried with Chris Davenport to standardise these strings and we just gave up. There are so many in so many places and as for consistency well that's a complete mystery

avatar ChristineWk
ChristineWk - comment - 2 Jan 2021

I have tested this item successfully on 01266d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31832.

avatar ChristineWk ChristineWk - test_item - 2 Jan 2021 - Tested successfully
avatar gostn
gostn - comment - 2 Jan 2021

I have tested this item successfully on 01266d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31832.

avatar gostn gostn - test_item - 2 Jan 2021 - Tested successfully
avatar richard67 richard67 - change - 2 Jan 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31832.

avatar richard67 richard67 - change - 2 Jan 2021
Labels Added: ? ? ?
avatar chmst chmst - change - 2 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-02 22:19:33
Closed_By chmst
Labels
avatar chmst chmst - close - 2 Jan 2021
avatar chmst chmst - merge - 2 Jan 2021
avatar chmst
chmst - comment - 2 Jan 2021

Thanks!

avatar brianteeman
brianteeman - comment - 2 Jan 2021

This should not have been merged it is not correct
I will do a correction

Add a Comment

Login with GitHub to post a comment