[#31833] - [4.0] Cleanup build files that have been removed
- Fixed in Code Base
- 3 Jan 2021
- Medium
- Build: 4.0-dev
- # 31833
- Diff
- wilsonge:feature/cleanup-build-files
User tests: Successful: Unsuccessful:
Summary of Changes
Removes various files from exclusion files that no longer exist in the top level of the repo (they've either been removed or moved to the build subfolder)
Testing Instructions
Code Review
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Unit Tests |
| Title |
|
||||||
Apply PR with Joomla! Patch Tester and there isn't file to modify.
@richard67 have you install J! with PR integrated?
@adj9 This PR can't be applied with patchtester on a "normal" Joomla installation made with an installation package, because it handles files in the build and the tests folders. Those folders are only available on a Git clone of the 4.0-dev branch.
Update: The same applies to the installation package built for this PR. It needs a git clone for testing it. Anyway it can be tested only by code review by a reviewer who is familiar with the J4 build process.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31833.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31833.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-03 19:52:21 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
Thnaks
I have tested this item✅ successfully on 9834d5f
Code review: I can confirm that the files have been removed or moved to the build folder where they are already ignored and not packed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31833.